diff options
| author | Wolfgang Walther <walther@technowledgy.de> | 2025-11-03 19:28:43 +0100 |
|---|---|---|
| committer | Wolfgang Walther <walther@technowledgy.de> | 2025-11-03 19:28:43 +0100 |
| commit | c768b4243eacf2a965338fe7f4fbdaf7f83d931d (patch) | |
| tree | 6f23c9886ac2c0f63237fc114fabd3c9d16c4d6a /pkgs/development/python-modules/termplotlib/gnuplot-subprocess.patch | |
| parent | 56dec699a244539d32a00a11c6c18a27a9c5c4a7 (diff) | |
ci/github-script/bot: fix infinite labeling cycle
When we recently refactored the code to use the maintainer map for
related labels, we made a mistake: When a PR has no packages with
maintainers returned from eval, the label would internally be set to `0`
instead of `false`.
The code would then go on compare the before and after labels with
strict equality - and assume a difference, because `0 !== false`. Thus,
it seemed like new labels needed to be set, so the PUT request was
actually sent. Of course, the labels were actually the same - when
filtering the labels to be set, the `0` would also be treated as falsy,
so the label would not be set. This would result in no visible change in
the PR, but internall GitHub would replace the `updated_at` timestamp
for that PR - after all we replaced all labels.
Repeatedly updating *all* PRs we're looking at quickly causes problems,
because we are going to look at the same PRs *again* in the next cycle -
essentially causing infinite recursion. The bot became slower and slower
over time, because it had to process more and more PRs each run.
Simply casting this to a proper Boolean, should get us out of the mess
soon.
Diffstat (limited to 'pkgs/development/python-modules/termplotlib/gnuplot-subprocess.patch')
0 files changed, 0 insertions, 0 deletions
