diff options
| author | Marien Zwart <marienz@google.com> | 2025-10-17 20:55:50 +1100 |
|---|---|---|
| committer | Marien Zwart <marienz@google.com> | 2025-10-19 15:50:50 +1100 |
| commit | 17cb17c7009b030aef05ac855f6e85d2a6cfce76 (patch) | |
| tree | 9108e35a2b02996c0c34a29f69711cec474665cd /pkgs/development/python-modules/robotframework-pythonlibcore | |
| parent | 0bd2e2737cc9381cb83b273415e531c8cdc29981 (diff) | |
emacsPackages: don't set attributes to null
Depending on the version of the package from MELPA, nixpkgs can set
attributes like `preBuild` or `patches` to `null`. `mkDerivation`
filters out `null`, so this has the desirable effect of not
unnecessarily changing the actual derivation. But it is inconvenient
when using `overrideAttrs`: it breaks the common pattern of
`(previousAttrs.preBuild or "") + ''...''` (also used elsewhere in the
files this commit changes), which will fail to coerce `null` to a string
or list to append to.
Fix this everywhere attributes are set to null, by defaulting to `""` or
`[ ]` instead.
We cannot set the attribute conditionally, because the attributes names
returned by `overrideAttrs` cannot depend on `finalAttrs` (only the
values can).
This changes some helpers that are (indirectly) used by several
packages, but that part of the change is effectively a noop, because the
attributes involved are always set (either by the helper or on the
original derivation).
Diffstat (limited to 'pkgs/development/python-modules/robotframework-pythonlibcore')
0 files changed, 0 insertions, 0 deletions
