summaryrefslogtreecommitdiff
path: root/pkgs/development/python-modules/rangehttpserver
diff options
context:
space:
mode:
authorJan Tojnar <jtojnar@gmail.com>2023-11-19 17:05:49 +0100
committerJan Tojnar <jtojnar@gmail.com>2023-11-19 18:44:48 +0100
commitff61f2bb3ff587df1a81c54f0f1b31bce46eec01 (patch)
treedf208f7a398ed6836322d81446dc8147330ced51 /pkgs/development/python-modules/rangehttpserver
parentc757e9bd77b16ca2e03c89bf8bc9ecb28e0c06ad (diff)
gnome.gdm: Simplify DESTDIR hack
Let’s point `DESTDIR` to a path under the build directory rather than under "$out". This will prevent `installPhase` from creating `$out` or any other output directory, allowing us to install the outputs just by moving them out of `$DESTDIR` directly into the store with `mv`. Of course, that will also require moving the installing of `etc` after the outputs are installed. Since `$out` does not currently contain `etc` subdirectory, we can also just move `$DESTDIR/etc` directly to `$out` rather than copying it. And even if `$out/etc` existed, we could just merge it with `cp --recursive` instead of `rsync` so `rsync` is not actually necessary. The code remains written defensively against files accidentally being misplaced while shuffling them around – parent directories of targets are used as `mv` destinations so that the move fails loudly if the directory already exists, rather than being moved inside as e.g. `$out/etc/etc`. While at it let’s also improve practices a bit: - Quote command arguments. - Move `DESTDIR` definition into `env` block. - Add vertical space and clearer comments. - Handle non-standard Nix store paths.
Diffstat (limited to 'pkgs/development/python-modules/rangehttpserver')
0 files changed, 0 insertions, 0 deletions