diff options
| author | Philip Taron <philip.taron@gmail.com> | 2024-07-29 11:28:26 -0700 |
|---|---|---|
| committer | Philip Taron <philip.taron@gmail.com> | 2024-07-29 11:29:15 -0700 |
| commit | 587f64a26459ffb7f2af0a7a0d454b4a6a76aec4 (patch) | |
| tree | 176fd34e1bbb965c471bd75dad7dd1aaeed8aff4 /pkgs/development/python-modules/rangehttpserver | |
| parent | f4f322d1424aa547eba9cb092f905f5ceb9b639c (diff) | |
nixpkgs-manual: use injected revision only
`lib.trivial.revisionWithDefault` will change with every Git commit, which causes the manual to be rebuilt on every since PR.
Using `nixpkgs.rev` (or the dummy value "master" if it's not present) means that the manual will contain the revision if built on Hydra, but will not otherwise.
Why?
1. https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-configuration shows that `pkgs/top-level/release.nix` is passed the `nixpkgs` attrset, which is a "Git checkout".
2. Git checkouts come from [`builtins.fetchGit`](https://nix.dev/manual/nix/2.18/language/builtins#builtins-fetchGit) and include the `rev` attribute.
3. The `rev` attribute is what `lib.trivial.revisionWithDefault` would have returned.
So, using `nixpkgs.rev or "master"` exclusively will cause the rebuilds on every commit to cease, but will allow "official" nixpkgs manual built on Hydra to continue to reference a specific commit.
Diffstat (limited to 'pkgs/development/python-modules/rangehttpserver')
0 files changed, 0 insertions, 0 deletions