diff options
| author | Wolfgang Walther <walther@technowledgy.de> | 2025-09-28 18:18:03 +0200 |
|---|---|---|
| committer | Wolfgang Walther <walther@technowledgy.de> | 2025-09-28 18:22:01 +0200 |
| commit | f7d6d11e8e8e046faaa6fbc55c2c1312e967cf04 (patch) | |
| tree | bf0f38a077c5ef3c85566ca29faf7fde6e74e973 /pkgs/development/python-modules/python-openstackclient/git@git.tavy.me:nixos | |
| parent | 8353fec872bca90282343d7a73f506f8c7008d4e (diff) | |
workflows/check: don't check github api for owners file
This removes the "owners" check from codeowners-validator. With it, all
tokens and permissions can be removed, because these were only needed to
make these requests.
This solves the problem of codeowners-validator not supporting our new
nested team structure for nixpkgs-maintainers. To make the onboarding of
new teams easier, we moved all teams "under" the nixpkgs-maintainers
team. This makes them inherit the right privileges (triage) for Nixpkgs.
However, this inheritance is not recognized by codeowners-validator,
thus it assumes that these teams don't have access to Nixpkgs. This then
fails the owners check immediately.
Removing the owners check also has a few other advantages:
- This check depends on external state: If a user is renamed or a team
removed, the check will fail. This makes it a bad check for required
status checks or merge queues - the check might fail randomly,
independent of the current PR.
- Running this check in a fork will never work, because the respective
users and teams don't have access to the fork's repo.
Both of this required us to set `continue-on-error: true` most of the
time.
Diffstat (limited to 'pkgs/development/python-modules/python-openstackclient/git@git.tavy.me:nixos')
0 files changed, 0 insertions, 0 deletions
