diff options
| author | Peter Waller <p@pwaller.net> | 2023-09-03 13:44:28 +0100 |
|---|---|---|
| committer | Peter Waller <p@pwaller.net> | 2023-09-03 13:49:50 +0100 |
| commit | e08ce498f03f12ae155b29a35c24adb26d4e8888 (patch) | |
| tree | 79a8cdbc3ce2eddef438ab16d2751c64e6941d60 /pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch | |
| parent | c2b0edbf1f74b67643402ff0ae251fe6f604d851 (diff) | |
cc-wrapper: Account for NIX_LDFLAGS and NIX_CFLAGS_LINK in linkType
Without this, pkgsStatic.pkgsLLVM.hello fails with segfaulting binaries
because of the issue described at [0].
In summary, llvm's linker has a different behaviour to GCC's when
supplied with both -static and -Wl,-dynamic-linker=...; GCC copes with
it, but LLVM produces a binary which segfaults on startup. It appears to
be necessary to omit the dynamic linker in this case.
nixpkgs' static adaptor passes -static via NIX_CFLAGS_LINK which was not
accounted for prior to this commit in the checkLinkType logic. For good
measure I put the other NIX_ flags affecting link in the same logic.
Additionally, $NIX_CFLAGS_LINK_@suffixSalt@ is not available until later
than it was originally set, so set $linkType close to its point of use.
I checked for earlier uses by studying the shell trace output and
couldn't find any.
[0] https://github.com/NixOS/nixpkgs/issues/111010#issuecomment-1536424163
Signed-off-by: Peter Waller <p@pwaller.net>
Diffstat (limited to 'pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch')
0 files changed, 0 insertions, 0 deletions
