summaryrefslogtreecommitdiff
path: root/pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch
diff options
context:
space:
mode:
authorAlyssa Ross <hi@alyssa.is>2024-09-02 17:35:20 +0200
committerAlyssa Ross <hi@alyssa.is>2024-09-23 21:08:38 +0200
commit1c953b1def0291551328199d430029bbea8cd10a (patch)
tree2d26f4e89895667152a92d25d6d3c3df782b67ed /pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch
parentd108ef0484a09a5c5d4216c0932f9c5632ce2a53 (diff)
Revert "llvmPackages.clangUseLLVM: add --undefined-version by default"
This reverts commit 019d0919383f5b28f0339020bb85fb291000bf54. My comments from the PR (which I only saw after it was merged): > I'm not convinced this is a good idea — compiler authors turn things > into errors for a reason, and as a distribution we have our part to > play in getting problematic things fixed. It's fine to disable the > errors for packages where it's not reasonably possible to get them > fixed, but doing it globally means even packages that would be > simple to fix properly don't get fixed. > To expand a bit, the problem with this sort of thing is that it's > very difficult later to tell when it can be removed. By setting this > globally instead of setting it for individual packages that need it, > we're effectively stuck with it forever, because it's impossible to > tell if removing it is going to break any packages. If we mark > packages individually, it's very easy to tell in future when those > markings can be removed. > > This isn't a theoretical concern: something similar was done for > pkgsMusl — some compatibility headers were added globally, instead > of fixing individual affected packages, and now, even though we've > discovered that the presence of those headers actually causes > problems for other packages, it's impossible to know what the > fallout would be of removing it. Let's not repeat this mistake. So let's revert now, before it's too late.
Diffstat (limited to 'pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch')
0 files changed, 0 insertions, 0 deletions