summaryrefslogtreecommitdiff
path: root/drivers/staging/rtl8723bs/hal
AgeCommit message (Collapse)Author
2026-07-28staging: rtl8723bs: remove unused enumerationsNikolay Kulikov
These enumerations and their values are never used anywhere else; remove them. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260727-rtl8723bs_rmove_enums-v1-1-7974aab6c86e@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapperArsenii Pashchenko
Collapse the static CamelCase helper function ReadChipVersion8723B() directly into the main rtl8723b_read_chip_version() function. This removes unnecessary code nesting and cleans up the CamelCase naming violation in a single atomic change. Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com> Link: https://patch.msgid.link/20260718041431.9174-1-ulijg308@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove debug fields from hal_com_dataNikolay Kulikov
These fields are never set. They are never read from, since GetHalDefVar() function never receives the neccessary constants. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-10-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove 'rf_chip' from struct hal_com_dataNikolay Kulikov
The 'rf_chip' field is set to only one value (RF_6052), which makes any conditions with this field predictable. Remove it and the associated static functions (_ReadRFType() and _InitRFType()), since they simply set a value in the field and will be empty without it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-9-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused spinlock 'SdioTxFIFOFreePageLock'Nikolay Kulikov
Remove the 'SdioTxFIFOFreePageLock' spinlock from the struct hal_com_data, since the only operation performed on it is initialization, while the locking and unlocking calls are commented out. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-8-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused 'UsbRxHighSpeedMode' from hal_com_dataNikolay Kulikov
The value 'false' is written to this field but is not used. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-7-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: hal: remove unused readings from the chipNikolay Kulikov
These values are read from the chip but never used. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-6-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused 'bNeedIQK' from struct hal_com_dataNikolay Kulikov
The value 'true' is written to this field, but it is never used. Remove it and the case branch, as the latter becomes meaningless. This also requires removing calls to rtw_hal_set_hwreg() with the 'HW_VAR_DO_IQK' argument to prevent execution of the default branch containing the netdev_dbg() call in SetHwReg(). Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-5-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused 'bIQKInitialized ' from hal_com_dataNikolay Kulikov
This field is always initialized to 'false' but is never used. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-4-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused array MCSTxPowerLevelOriginalOffsetNikolay Kulikov
Remove the 'MCSTxPowerLevelOriginalOffset' array and the 'pwrGroupCnt' field (which is used as an index for that array), as values are being written to it but are no longer used. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: remove unused 'CCK_24G_Diff' from hal_com_dataNikolay Kulikov
Values are written to this array, but they are never used. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260717185407.56513-2-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: wrap line over 100 charactersDalvin-Ehinoma Noah Aiguobas
Fix checkpatch warning by wrapping the lines. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/20260717161329.3400-3-fliegbert2@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-28staging: rtl8723bs: change struct member bDriverStoppedDalvin-Ehinoma Noah Aiguobas
Member name does not adhere to linux coding style. Changed type as well since b indicates a boolean type and in every instance of setting the variable the values true and false are used. bDriverStopped -> driver_stopped Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/20260717161329.3400-2-fliegbert2@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: convert rtw_xmitframe_coalesce() to return errnoHungyu Lin
Convert rtw_xmitframe_coalesce() to return 0 on success and a negative errno on failure. Propagate errno values returned by the helper functions instead of converting them to _FAIL. No functional change intended. Signed-off-by: Hungyu Lin <dennylin0707@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260713070537.15903-6-dennylin0707@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: remove unused 'bTXPowerDataReadFromEEPORM'Nikolay Kulikov
The 'bTXPowerDataReadFromEEPORM' field of the struct hal_com_data is set but never used; remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260710165220.68599-6-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: remove unused EEPROMBluetoothType from hal_com_dataNikolay Kulikov
The value 'BT_RTL8723B' is written to this field, but it is not used in any other way, so remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260710165220.68599-5-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: remove unused EEPROMVersion from struct hal_com_dataNikolay Kulikov
A value is written to this field, but it is never used. Remove it, along with the associated functions and macros, to simplify the code. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260710165220.68599-4-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: remove unused ForcedDataRate from hal_com_dataNikolay Kulikov
This field is set once and never used, so remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260710165220.68599-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: remove unused 'EEPROMCustomerID' from hal_com_dataNikolay Kulikov
This field is set during initialization but never used, so remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260710165220.68599-2-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-17staging: rtl8723bs: Rename camelcase enum value dot11AuthAlgrthm_8021XDalvin-Ehinoma Noah Aiguobas
Rename enum value dot11AuthAlgrthm_8021X to dot11_auth_algrthm_8021x to fix the checkpatch.pl CamelCase finding. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/20260710162017.5660-2-fliegbert2@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-10staging: rtl8723bs: remove unused 'MultiFunc' from struct hal_com_dataNikolay Kulikov
This field is set during initialization but never used, so remove it and related macros and enum. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260709182627.16327-5-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-10staging: rtl8723bs: remove unused RegulatorMode from struct hal_com_dataNikolay Kulikov
This variable is set during initialization but never used, so remove it. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260709182627.16327-4-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-10staging: rtl8723bs: remove unused 'PolarityCtl' from struct hal_com_dataNikolay Kulikov
This field is determined by the value of a bit from the hardware, but the variable is not used after assignment. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260709182627.16327-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-10staging: rtl8723bs: Rename camelcase struct member dot11PrivacyAlgrthmDalvin-Ehinoma Noah Aiguobas
Rename struct member dot11PrivacyAlgrthm to dot11_privacy_algrthm in struct security_priv to resolve checkpatch.pl CamelCase finding. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/20260708190102.2104-1-fliegbert2@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-10staging: rtl8723bs: replace beacon timing magic numbers with named constantsJad Keskes
Break down the 0x6404 and 0x660F in rtl8723b_InitBeaconParameters() as requested by the TODO in the source. REG_TBTT_PROHIBIT (0x0540): 0x6404 = hold (0x64) and setup (0x04), both in 32us ticks. Same layout as rtw88 (WLAN_TBTT_HOLD_TIME << 8 | WLAN_TBTT_PROHIBIT in rtw88.h). REG_BCNTCFG (0x0510): 0x660F is an EDCA-like register. Lower byte is AIFS (0x0F = no contention before beacon), next nibble is CWmin (0x06), top nibble is CWmax (0x06). Confirmed by rtl8192du/rtl8723ae in the tree which write 0x66FF (test chips) and 0x660F (production) — only AIFS varies, the CW byte stays 0x66. The out-of-tree driver that Dan linked in the TODO discussion was the reference for the bit assignments: Link: https://lore.kernel.org/all/aiGMXBNQ0TbIGbpP@stanley.mountain/ Drop the TODO since this was the last thing it referenced. Signed-off-by: Jad Keskes <inasj268@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260708150930.1813224-1-inasj268@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: use rS0S1_PathSwitch define instead of 0x948 magic numberPanagiotis Petrakopoulos
Using magic numbers is error prone. The address 0x948 already has a define, rS0S1_PathSwitch, in Hal8192CPhyReg.h. Replace the occurrences of the magic number 0x948 with the rS0S1_PathSwitch define for more clarity and readability. No functional change intended. Signed-off-by: Panagiotis Petrakopoulos <npetrakopoulos2003@gmail.com> Link: https://patch.msgid.link/20260705153243.32484-1-npetrakopoulos2003@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Add braces to if statement in rtl8723bs_cmd.cAlonso Garrigues
Add braces so all blocks in an if else statement are consistent as per kernel coding style. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-7-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unnecessary parentheses in rtl8723b_cmd.cAlonso Garrigues
Remove unnecessary parentheses around address-of structure members. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-6-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove dead code in rtl8723b_cmd.cAlonso Garrigues
Remove commented-out old code to help readability. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-5-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix lines ending in '(' in rtl8723b_cmd.cAlonso Garrigues
Align parameters in function calls and definitions with the opening parentheses to conform to the coding style. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-4-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: correct binary operator style in rtl8723bs_cmd.cAlonso Garrigues
Add spaces around binary operators to improve readability. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-3-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove dead code block in rtl8723bs_cmd.cAlonso Garrigues
Remove commented-out dead code block for readability. Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260630163316.1128319-2-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove local variable 'eRFPath'Nikolay Kulikov
After removing the loop from the phy_RF6052_Config_ParaFile() function, the value of this variable can no longer be changed, allowing all switch-case statements to be known in advance, since it stores the value 0 (which is 'RF_PATH_A', defined in enum rf_path). Therefore, remove it and the associated dead code and access 'RF_PATH_A' directly. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260621161611.111461-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove 'NumTotalRFPath' from 'struct hal_com_data'Nikolay Kulikov
This variable is assigned the value 1, after which it is used as a loop delimiter. Since it always stores 1, only one loop iteration is performed. We can remove the 'NumTotalRFPath' field and remove the loop by calling its body directly to simplify the code. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260621161611.111461-2-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unnecessary braces in hal_intf.cAlonso Garrigues
Single statement blocks do not need braces if and else blocks should have consistent bracing Signed-off-by: Alonso Garrigues <agarrigues@riseup.net> Link: https://patch.msgid.link/20260619191021.2205395-1-agarrigues@riseup.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Fix missing spaces around operatorsMoksh Panicker
Add missing spaces around arithmetic and bitwise operators ('+', '-', '&') in the rtl8723bs staging driver across multiple files. These were flagged by checkpatch.pl with: CHECK: spaces preferred around that 'X' (ctx:VxV) Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com> Reviewed-by: Dan Carpenter <error27@gmail.com> Link: https://patch.msgid.link/20260615082538.12007-1-mokshpanicker.7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in rtl8723bs_recv.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-7-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in rtl8723b_hal_init.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-6-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in HalPhyRf_8723B.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-4-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in hal_com.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-3-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in hal_btcoex.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-2-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: fix space-before-tab warnings in HalBtc8723b2Ant.cQuentin Strydom
Remove spaces before tabs in comments to match kernel coding style. Signed-off-by: Quentin Strydom <qstrydom0@gmail.com> Link: https://patch.msgid.link/20260612102834.39935-1-qstrydom0@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: use nl80211_iftype instead of custom NDIS enumCong Nguyen
The driver defined its own enum ndis_802_11_network_infrastructure to represent the operating mode (STA/AP/IBSS) and translated nl80211 iftypes into it in cfg80211_rtw_change_iface(). The kernel already provides enum nl80211_iftype for this purpose, so use it directly and drop the redundant translation layer. Map the removed values as follows: Ndis802_11IBSS -> NL80211_IFTYPE_ADHOC Ndis802_11Infrastructure -> NL80211_IFTYPE_STATION Ndis802_11APMode -> NL80211_IFTYPE_AP Ndis802_11AutoUnknown -> NL80211_IFTYPE_UNSPECIFIED Compile-tested only. Signed-off-by: Cong Nguyen <congnt264@gmail.com> Link: https://patch.msgid.link/20260707104836.3176765-1-congnt264@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: Rename camelcase variable dot11AuthAlgrthmDalvin-Ehinoma Noah Aiguobas
Rename variable dot11AuthAlgrthm to dot11_auth_algrthm in struct security_priv to resolve checkpatch.pl CamelCase finding. Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com> Link: https://patch.msgid.link/ahwHbMecWpijQBv9@koolguy Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove unused field 'bAPKThermalMeterIgnore'Nikolay Kulikov
This field is set to 'true' once and is never used again. Remove it to eliminate dead code. Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com> Link: https://patch.msgid.link/20260531080015.74870-1-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix space before tab in rtl8723b_dm.cPraveen Jayaprakash Pattar
Remove tab characters that appeared after '/*' in two comment lines, which caused 'please, no space before tabs' warnings. Replace the space+tab combination with a single space after the comment opener. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260531045511.5774-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix indentation in odm_EdcaTurboCheck.cPraveen Jayaprakash Pattar
Fix incorrect indentation of an if statement inside an else block. The statement had a space before it instead of proper tab alignment, causing checkpatch.pl to report 'suspect code indent' and 'statements should start on a tabstop' warnings. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260531040420.5426-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: fix spelling mistake found by codespellTomasz Unger
Corrected typo: FASLE -> FALSE in comment Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> Link: https://patch.msgid.link/20260526-fix-typo-odm-dig-v1-1-4392b0c03e13@yahoo.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: remove empty loop and stale comment in HalPhyRf.cIgor Putko
The 'for' loop in ODM_TXPowerTrackingCallback_ThermalMeter performs no operations and just iterates over the path count. This is unnecessary code. Also, remove the associated "Print Swing base & current" comment, as it no longer refers to any active code. Signed-off-by: Igor Putko <igorpetindev@gmail.com> Link: https://patch.msgid.link/20260525121004.4989-1-igorpetindev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2026-07-07staging: rtl8723bs: hal: Fix block comment style in HalPwrSeqCmd.cPraveen Jayaprakash Pattar
Fix non-standard block comment format. The comment was using '/*++' and '--*/' delimiters instead of the standard '/*' and '*/' used in kernel coding style. Also fix missing '*' prefix on subsequent lines and remove space before tab characters. Detected by checkpatch.pl with --strict flag. Signed-off-by: Praveen Jayaprakash Pattar <praveen.pattar2022@gmail.com> Link: https://patch.msgid.link/20260524152506.5670-1-praveen.pattar2022@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-09-10 04:17:45 +0000