diff options
| author | Malaya Kumar Rout <malayarout91@gmail.com> | 2026-07-04 16:27:36 +0530 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2026-07-05 09:36:41 +0200 |
| commit | cb89f0c1aed02eb233c4271f76f830b37e222ff6 (patch) | |
| tree | 98352e68ac592990f4eef31763553dad80f3eeaf /tools | |
| parent | b28d3d0841a6083f82dfa9fe940afcd748f2a1e2 (diff) | |
selftests/alsa: Fix memory leak in find_controls error path
In find_controls(), card_data is allocated with malloc() but when
snd_ctl_open_lconf() fails, the code jumps to next_card without
freeing the allocated memory. This results in a memory leak for
each card where snd_ctl_open_lconf() fails.
Add free(card_data) before goto next_card to ensure proper cleanup
of the allocated memory in the error path.
Fixes: 5aaf9efffc57 ("kselftest: alsa: Add simplistic test for ALSA mixer controls kselftest")
Signed-off-by: Malaya Kumar Rout <malayarout91@gmail.com>
Link: https://patch.msgid.link/20260704105736.94874-1-malayarout91@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/alsa/mixer-test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/testing/selftests/alsa/mixer-test.c b/tools/testing/selftests/alsa/mixer-test.c index d4f845c32804..c5ae2a026ce9 100644 --- a/tools/testing/selftests/alsa/mixer-test.c +++ b/tools/testing/selftests/alsa/mixer-test.c @@ -84,6 +84,7 @@ static void find_controls(void) if (err < 0) { ksft_print_msg("Failed to get hctl for card %d: %s\n", card, snd_strerror(err)); + free(card_data); goto next_card; } |