summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorBryam Vargas <hexlabsecurity@proton.me>2026-06-12 12:50:25 -0500
committerDavid Heidelberg <david@ixit.cz>2026-08-11 18:10:02 +0200
commit0428fa2c22e2ba0cff766d3b80d461e149102045 (patch)
treeac5802d68ac536baae8af161a5b063c715a992c7 /tools
parent78b20c8eeacd2e44a2d8a4cb5316d3c521d90911 (diff)
nfc: nci: add data_len bound checks to activation parameter extractors
nci_extract_activation_params_iso_dep() and nci_extract_activation_params_nfc_dep() read an inner length byte from the NCI RF_INTF_ACTIVATED_NTF payload and use it to memcpy() into fixed kernel buffers, but neither function receives the caller-validated activation_params_len. A crafted NCI notification with activation_params_len=1 and an inner length byte of up to 20 (NFC-A) or 50 (NFC-B) causes memcpy() to read that many bytes past the one valid byte in the activation params region -- a slab out-of-bounds read of kernel memory adjacent to the NCI skb. The sibling nci_extract_rf_params_*() family was given equivalent protection by commit 571dcbeb8e63 ("net: nfc: nci: Fix parameter validation for packet data"), but the two activation parameter extractors were not updated at that time. Add a data_len parameter to both functions, guard against an empty region before consuming the inner length byte, decrement the remaining count after consuming it, and clamp the copy length to what is actually available. Update both call sites to pass ntf.activation_params_len, which is already validated against the skb at ntf.c:801. Fixes: e8c0dacd9836 ("NFC: Update names and structs to NCI spec 1.0 d18") Cc: stable@vger.kernel.org Signed-off-by: Bryam Vargas <hexlabsecurity@proton.me> Link: https://patch.msgid.link/20260612-b4-disp-6d52d8b0-v3-1-e26221f8826d@proton.me Signed-off-by: David Heidelberg <david@ixit.cz>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions