summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2026-08-07 15:51:43 +0100
committerMark Brown <broonie@kernel.org>2026-08-07 15:51:43 +0100
commitdf63715765e1a49368040484845843499242f583 (patch)
treea2f03da26d83ce2aaf4158e70d6dd4ee5179aca1 /tools/perf/scripts/python
parentb45fc97ebcfb27ec250025329a4f79ce5e327ec3 (diff)
parent3521d209ca70bf77b8c1dcccab5ca4df9468877f (diff)
ASoC: TI codecs: sort the reg_defaults tables
Peter Ujfalusi <peter.ujfalusi@linux.intel.com> says: The reg_defaults array of a regmap_config must be sorted by ascending register address: regcache_lookup_reg() finds entries in it with bsearch(), and regcache_init() only kmemdup_array()s the array, it never sorts it. See commit fd80df352ba1 ("regcache: Add support for sorting defaults arrays"). When the array is not sorted, bsearch() descends into the wrong half and a number of entries can never be found. regcache_reg_needs_sync() then cannot compare the cached value against the default and always reports that a sync is needed, so those registers are written to the device on every regcache_sync() even if they were never touched. I found this while chasing a SoundWire NAK on an unimplemented register and audited the reg_defaults tables in sound/ by replaying lib/bsearch.c over each of them. These are the affected TI/Burr-Brown codecs: pcm512x_reg_defaults 45 entries, 24 unreachable tas675x_reg_defaults 69 entries, 14 unreachable tas2552_reg_defs 21 entries, 7 unreachable tas2764_reg_defaults 11 entries, 1 unreachable tas2780_reg_defaults 10 entries, 1 unreachable The patches only reorder the existing entries. The text of every entry is kept verbatim, no default value is changed, and each resulting table was verified to be fully reachable. tas2783-sdw was fixed separately, it had already been posted. Link: https://patch.msgid.link/20260805104149.9795-1-peter.ujfalusi@linux.intel.com
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions