diff options
| author | Troy Mitchell <troy.mitchell@linux.spacemit.com> | 2026-07-29 02:26:42 -0700 |
|---|---|---|
| committer | Linus Walleij <linusw@kernel.org> | 2026-08-03 09:46:23 +0200 |
| commit | 41c59b22370d2e1785e0e80f8ad7bd9946a1ca82 (patch) | |
| tree | 8a40c1d6ef499c746594fbeee9a8f5b2df0bfdf4 /tools/perf/scripts/python | |
| parent | 17007cd700601777d9ee203a13d97e64ece3a10f (diff) | |
pinctrl: spacemit: validate pins in pinconf callbacks
Pin 0 is a valid pin ID, but spacemit_pinconf_get() rejects it by
testing the numeric ID rather than the result of the descriptor lookup.
It also fails to reject nonzero IDs absent from the SoC pin table before
computing their register addresses. Check the descriptor and use its pin
ID for the register lookup.
spacemit_pinconf_group_set() validates only the first group member when
generating the configuration. If a later member is invalid,
spacemit_pin_set_config() returns -EINVAL, but the callback ignores it
and reports success after partially updating the group.
Validate every group member before writing any registers so malformed
groups fail without being partially applied.
Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Reviewed-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linus Walleij <linusw@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions
