diff options
| author | Uday Khare <udaykhare77@gmail.com> | 2026-06-18 18:53:27 +0530 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-07-01 12:20:53 +0100 |
| commit | 7fd28093b3effc4f92566466df364622830ec608 (patch) | |
| tree | 318cb35139723cfa7b4af2e672ce45a6f90bf363 /tools/perf/scripts/python/task-analyzer.py | |
| parent | a36cc103a6fb56ae3707c7bbae30f4e629d0da3c (diff) | |
regulator: tps6594: Fix device node reference leaks in multiphase loop
In tps6594_regulator_probe(), the multi-phase configuration loop calls
of_find_node_by_name() to find buck nodes by name, and of_get_parent()
twice to navigate to the PMIC parent node. None of the acquired node
references (np, intermediate parent, np_pmic_parent) are ever released
via of_node_put(), causing a reference leak on every loop iteration.
Additionally, of_find_node_by_name() can return NULL, but the result was
immediately passed to of_node_full_name() and of_get_parent() without a
NULL check, which could lead to a NULL pointer dereference.
Fix this by:
- Adding a NULL check for np after of_find_node_by_name()
- Storing the intermediate parent node in a local variable np_parent
- Calling of_node_put() on np, np_parent and np_pmic_parent at the
end of each loop iteration
Fixes: f17ccc5deb4d ("regulator: tps6594-regulator: Add driver for TI TPS6594 regulators")
Signed-off-by: Uday Khare <udaykhare77@gmail.com>
Link: https://patch.msgid.link/20260618132327.11529-1-udaykhare77@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions
