diff options
| author | Tvrtko Ursulin <tvrtko.ursulin@igalia.com> | 2026-06-02 16:33:39 +0100 |
|---|---|---|
| committer | Philipp Stanner <phasta@kernel.org> | 2026-06-10 08:18:49 +0200 |
| commit | 2df5efb45425b48fbf5a3c1f36a686af26871009 (patch) | |
| tree | d69eddfca8ea84f409ead400741a92a4f25d3117 /tools/perf/scripts/python/task-analyzer.py | |
| parent | 7a921d111810652672e02c392b35fdcefa4d5030 (diff) | |
drm/sched: Remove redundant entity->rq initialization and checks
Commit
28c5bf28763d ("drm/sched: Disallow initializing entities with no schedulers")
failed to notice clearing of entity->rq in drm_sched_entity_init() is now
redundant and can be removed.
Given that entity->rq can now never be NULL, we also remove two impossible
checks, from drm_sched_entity_kill() and drm_sched_entity_flush()
respectively.
Similarly, we can also remove the !entity->rq check in
drm_sched_job_init(). And for the better, given that the error message, if
it ever triggered, would have dereferenced the yet un-initialized job->
sched (only initialized later in drm_sched_job_arm()). This appears to
have been theoretically broken ever since commit
56e449603f0a ("drm/sched: Convert the GPU scheduler to variable number of run-queues")
.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <phasta@kernel.org>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20260602153339.43453-1-tvrtko.ursulin@igalia.com
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions
