diff options
| author | Mingyu Wang <25181214217@stu.xidian.edu.cn> | 2026-07-21 16:19:42 +0800 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2026-08-08 08:08:58 +0200 |
| commit | 81cc73be40c6f028f1ee3f438ace46afe666dbae (patch) | |
| tree | 4f0fc2b8ddd7926e3dd0aede0f9c36a20193a8aa /tools/perf/scripts/python/stackcollapse.py | |
| parent | 061db6b7a910b8378f3b2df64f8c0a3ddc6e85f2 (diff) | |
fbdev: core: Fix pointer desynchronization in fb_io_read()
In fb_io_read(), if copy_to_user() performs a partial copy (e.g., due to
a faulty user buffer), the loop adjusts the chunk size 'c' and updates
the remaining 'count'. However, the hardware 'src' pointer has already
been eagerly advanced by the original chunk size.
If the loop is allowed to continue, the read will resume from an
incorrect, over-advanced offset. Since the remaining 'count' was only
decremented by the successful bytes, this desynchronization causes the
next iterations to execute more hardware reads than originally bounded,
eventually leading to out-of-bounds I/O reads.
Fix this by breaking out of the loop immediately upon a partial
copy_to_user(). A partial copy indicates a faulty user buffer, making
subsequent read attempts futile. Breaking out ensures we return the
number of successfully read bytes without risking out-of-bounds hardware
accesses in subsequent mismatched iterations.
Fixes: 6121cd9ef911 ("fbdev: Move I/O read and write code into helper functions")
Cc: stable@vger.kernel.org
Signed-off-by: Mingyu Wang <25181214217@stu.xidian.edu.cn>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
