diff options
| author | Ivan Lazaric <ivan.lazaric1@gmail.com> | 2026-07-08 15:14:01 +0200 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2026-07-08 16:43:25 -0700 |
| commit | 261210854462ef5e587eb1b740aa06dbab3b3a40 (patch) | |
| tree | f9b076f5e53d12f8899f971126c1dd51de575ee6 /tools/perf/scripts/python/stackcollapse.py | |
| parent | eda39f98bbc5ce8b7b0be10193d2de38ed59da6c (diff) | |
perf stat: reject --field-separator and --json-output combination
Specifying --field-separator option is stating you want CSV output.
Passing both --field-separator and --json-output is then stating
you want output to be in CSV and JSON format at same time.
Currently this combination is not rejected, and the outcome
is a malformed combination of CSV and JSON output.
This is because of inconsistencies in various printing functions,
some of them have if-else chains that start with
"Should I print JSON?", and some start with "Should I print CSV?".
Example of current output:
$ tools/perf/perf stat -x , -j -e cpu-migrations true
{"counter-value" : "0.000000", "unit" : "", "event" : "cpu-migrations", "event-runtime" : 474817, "pcnt-running" : 100.00,,
Instead reject the option combination,
with a helpful error message and non-zero exit code.
Example of new output:
$ tools/perf/perf stat -x , -j true
cannot use both --field-separator and --json-output
Usage: perf stat [<options>] [<command>]
-x, --field-separator <separator>
print counts with custom separator
-j, --json-output print counts in JSON format
Signed-off-by: Ivan Lazaric <ivan.lazaric1@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
