diff options
| author | Babanpreet Singh <bbnpreetsingh@gmail.com> | 2026-07-13 06:08:06 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-07-19 23:55:48 +0100 |
| commit | fc46551cfa3b30ac96ee40a0cdb61c35b063ba8c (patch) | |
| tree | 7a29cb3271dc30cec0ad580f525d7f208cdfd563 /tools/perf/scripts/python/libxed.py | |
| parent | 1590cf0329716306e948a8fc29f1d3ee87d3989f (diff) | |
spi: axiado: merge identical if/else branches in ax_transfer_one()
The else-if arm taken for RX-only and full-duplex transfers and the
trailing else arm in the RX bookkeeping setup of ax_transfer_one()
have identical bodies, so the second condition has no effect:
drivers/spi/spi-axiado.c:433:8-10: WARNING: possible condition with
no effect (if == else)
The trailing else arm (neither TX nor RX buffer) is also unreachable:
the SPI core only calls the ->transfer_one() callback for transfers
that carry at least one buffer, see spi_transfer_one_message().
Merge the two arms into a single else branch and fold their comments.
No functional change. The redundant condition has been present since
the driver was added in commit e75a6b00ad79 ("spi: axiado: Add driver
for Axiado SPI DB controller").
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202607121827.djB0zLAj-lkp@intel.com/
Assisted-by: Claude:claude-fable-5 [coccinelle]
Signed-off-by: Babanpreet Singh <bbnpreetsingh@gmail.com>
Link: https://patch.msgid.link/20260713060807.7-2-bbnpreetsingh@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/libxed.py')
0 files changed, 0 insertions, 0 deletions
