diff options
| author | Zilin Guan <zilin@seu.edu.cn> | 2026-01-22 08:59:45 +0000 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2026-01-27 13:43:14 +0100 |
| commit | 9b50d9c06c275419ac36de8b5a5dd1ed6b522770 (patch) | |
| tree | 636d07d7762be9652dbbdf3f315b516f3dcad057 /tools/perf/lib/Documentation/tutorial/git@git.tavy.me:linux.git | |
| parent | fd5bfcf430ea2fdbb3e78fd0b82ceb0ab02b72ee (diff) | |
wifi: p54: Fix memory leak in p54_beacon_update()
In p54_beacon_update(), beacon is allocated via ieee80211_beacon_get().
If p54_beacon_format_ie_tim() fails, the function returns immediately
without freeing the allocated beacon skb, which would lead to a memory
leak.
Since no other references to this memory exist, it must be freed locally
before returning the error. Fix this by freeing the buffer using
dev_kfree_skb_any() in the error path.
Note that this error path is unreachable in practice because mac80211
guarantees a minimum TIM length of 4 bytes for non-S1G devices. This
change primarily serves to silence static analysis warnings and keep
the error handling logic complete.
Compile tested only. Issue found using a prototype static analysis tool
and code review.
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Link: https://patch.msgid.link/20260122085945.444955-1-zilin@seu.edu.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'tools/perf/lib/Documentation/tutorial/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
