summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorJie Gan <jie.gan@oss.qualcomm.com>2026-05-12 09:56:07 +0800
committerSuzuki K Poulose <suzuki.poulose@arm.com>2026-05-12 16:33:23 +0100
commitf4526ffee6ff9f5845b430957417149eded74bf3 (patch)
treeeaf9b478b911d41b46d441588e0070efc22177d1 /scripts
parent0ec0a8785d21f63db520bd9d2a67c55e855d36a8 (diff)
coresight: fix missing error code when trace ID is invalid
When coresight_path_assign_trace_id() cannot assign a valid trace ID, coresight_enable_sysfs() takes the err_path goto with ret still 0, returning success to the caller despite no trace session being started. Change coresight_path_assign_trace_id() to return int, moving the IS_VALID_CS_TRACE_ID() check inside it so it returns -EINVAL on failure and 0 on success. Update both callers to propagate this return value directly instead of inspecting path->trace_id after the call. Fixes: d87d76d823d1 ("Coresight: Allocate trace ID after building the path") Reviewed-by: James Clark <james.clark@linaro.org> Reviewed-by: Richard Cheng <icheng@nvidia.com> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com> Reviewed-by: Leo Yan <leo.yan@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> Link: https://lore.kernel.org/r/20260512-fix-trace-id-error-v4-1-eb3de789767a@oss.qualcomm.com
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions