summaryrefslogtreecommitdiff
path: root/rust/kernel/debugfs/git@git.tavy.me:linux.git
diff options
context:
space:
mode:
authorDavid Hildenbrand (Red Hat) <david@kernel.org>2025-12-23 22:40:35 +0100
committerAndrew Morton <akpm@linux-foundation.org>2026-01-20 09:34:26 -0800
commit3937027caecb4f8251e82dd857ba1d749bb5a428 (patch)
treea13a4e3c04bcfcc5895c038beaf50ea111b8d5c6 /rust/kernel/debugfs/git@git.tavy.me:linux.git
parentca1a47cd3f5f4c46ca188b1c9a27af87d1ab2216 (diff)
mm/hugetlb: fix two comments related to huge_pmd_unshare()
Ever since we stopped using the page count to detect shared PMD page tables, these comments are outdated. The only reason we have to flush the TLB early is because once we drop the i_mmap_rwsem, the previously shared page table could get freed (to then get reallocated and used for other purpose). So we really have to flush the TLB before that could happen. So let's simplify the comments a bit. The "If we unshared PMDs, the TLB flush was not recorded in mmu_gather." part introduced as in commit a4a118f2eead ("hugetlbfs: flush TLBs correctly after huge_pmd_unshare") was confusing: sure it is recorded in the mmu_gather, otherwise tlb_flush_mmu_tlbonly() wouldn't do anything. So let's drop that comment while at it as well. We'll centralize these comments in a single helper as we rework the code next. Link: https://lkml.kernel.org/r/20251223214037.580860-3-david@kernel.org Fixes: 59d9094df3d7 ("mm: hugetlb: independent PMD page table shared count") Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org> Reviewed-by: Rik van Riel <riel@surriel.com> Tested-by: Laurence Oberman <loberman@redhat.com> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Acked-by: Oscar Salvador <osalvador@suse.de> Reviewed-by: Harry Yoo <harry.yoo@oracle.com> Cc: Liu Shixin <liushixin2@huawei.com> Cc: Lance Yang <lance.yang@linux.dev> Cc: "Uschakow, Stanislav" <suschako@amazon.de> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'rust/kernel/debugfs/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions