summaryrefslogtreecommitdiff
path: root/include/net/tipc/git@git.tavy.me:linux.git
diff options
context:
space:
mode:
authorSanman Pradhan <psanman@juniper.net>2026-03-19 17:31:19 +0000
committerGuenter Roeck <linux@roeck-us.net>2026-03-24 07:55:08 -0700
commitf7e775c4694782844c66da5316fed82881835cf8 (patch)
tree4e29a9e7ce3841f0582bf4d02dc7b230bd2ec203 /include/net/tipc/git@git.tavy.me:linux.git
parentc369299895a591d96745d6492d4888259b004a9e (diff)
hwmon: (pmbus/ina233) Fix error handling and sign extension in shunt voltage read
ina233_read_word_data() reads MFR_READ_VSHUNT via pmbus_read_word_data() but has two issues: 1. The return value is not checked for errors before being used in arithmetic. A negative error code from a failed I2C transaction is passed directly to DIV_ROUND_CLOSEST(), producing garbage data. 2. MFR_READ_VSHUNT is a 16-bit two's complement value. Negative shunt voltages (values with bit 15 set) are treated as large positive values since pmbus_read_word_data() returns them zero-extended in an int. This leads to incorrect scaling in the VIN coefficient conversion. Fix both issues by adding an error check, casting to s16 for proper sign extension, and clamping the result to a valid non-negative range. The clamp is necessary because read_word_data callbacks must return non-negative values on success (negative values indicate errors to the pmbus core). Fixes: b64b6cb163f16 ("hwmon: Add driver for TI INA233 Current and Power Monitor") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan <psanman@juniper.net> Link: https://lore.kernel.org/r/20260319173055.125271-2-sanman.pradhan@hpe.com [groeck: Fixed clamp to avoid losing the sign bit] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'include/net/tipc/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions