diff options
| author | Guangshuo Li <lgs201920130244@gmail.com> | 2026-04-13 21:53:43 +0800 |
|---|---|---|
| committer | Rafael J. Wysocki <rjw@rjwysocki.net> | 2026-04-15 16:43:58 +0200 |
| commit | 9c0acc169ac71535477caedea8315f7041c5f07c (patch) | |
| tree | 7349c9b869334b1adac6aeea04fca9174d90dee9 /include/linux/timerqueue.h | |
| parent | 2e31b16101834bdc0b720967845d6a0a309cf27b (diff) | |
ACPI: scan: Use acpi_dev_put() in object add error paths
After acpi_init_device_object(), the lifetime of struct acpi_device is
managed by the driver core through reference counting.
Both acpi_add_power_resource() and acpi_add_single_object() call
acpi_init_device_object() and then invoke acpi_device_add(). If that
fails, their error paths call the release callback directly instead of
dropping the device reference through acpi_dev_put().
This bypasses the normal device lifetime rules and frees the object
without releasing the reference acquired by device_initialize(), which
may lead to a refcount leak.
The issue was identified by a static analysis tool I developed and
confirmed by manual review.
Fix both error paths by using acpi_dev_put() and let the release
callback handle the final cleanup.
Fixes: 781d737c7466 ("ACPI: Drop power resources driver")
Fixes: 718fb0de8ff88 ("ACPI: fix NULL bug for HID/UID string")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Link: https://patch.msgid.link/20260413135343.2884481-1-lgs201920130244@gmail.com
Signed-off-by: Rafael J. Wysocki <rjw@rjwysocki.net>
Diffstat (limited to 'include/linux/timerqueue.h')
0 files changed, 0 insertions, 0 deletions
