diff options
| author | Geliang Tang <tanggeliang@kylinos.cn> | 2026-05-26 17:22:22 +0800 |
|---|---|---|
| committer | Keith Busch <kbusch@kernel.org> | 2026-05-27 07:16:49 -0700 |
| commit | 4dae393956093c807212918fd91a8fc70df15338 (patch) | |
| tree | 69ece656b4617bfb2d7ce86b9646dfc2745c6aef /include/linux/timerqueue.h | |
| parent | 6022a5330fa2eabce7f20a23200e14a771640f1a (diff) | |
nvmet-tcp: fix page fragment cache leak in error path
In nvmet_tcp_alloc_queue(), when a connection is closed during the
allocation process (e.g., nvmet_tcp_set_queue_sock() returns -ENOTCONN),
the error handling jumps to out_destroy_sq and then to out_ida_remove
without draining the page fragment cache.
Although nvmet_tcp_free_cmd() is called in some error paths to release
individual page fragments, the underlying page cache reference held by
queue->pf_cache is never released. The first allocation using pf_cache
is the call to nvmet_tcp_alloc_cmd() for queue->connect, which happens
after ida_alloc() returns successfully. This results in a page leak each
time a connection fails during allocation, which could lead to memory
exhaustion over time if connections are repeatedly opened and closed.
Fix this by calling page_frag_cache_drain() before freeing the queue
structure in the out_ida_remove label.
Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'include/linux/timerqueue.h')
0 files changed, 0 insertions, 0 deletions
