diff options
| author | Sachin Mokashi <sachin.mokashi@intel.com> | 2026-03-27 09:14:39 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-03-31 12:37:13 +0100 |
| commit | 51e3eb3d074a8c7c306d447612011cf8568c8d6f (patch) | |
| tree | 90bccf4829a55a2c6a6548f58891dc86fcee4303 /fs/devfs/git@git.tavy.me:linux.git | |
| parent | 622363757b2286dd2c2984b0d80255cbb35a0495 (diff) | |
ASoC: Intel: ehl_rt5660: Use the correct rtd->dev device in hw_params
In rt5660_hw_params(), the error path for snd_soc_dai_set_sysclk()
correctly uses rtd->dev as the logging device, but the error path for
snd_soc_dai_set_pll() uses codec_dai->dev instead.
These two devices are distinct:
- rtd->dev is the platform device of the PCM runtime (the Intel HDA/SSP
controller, e.g. 0000:00:1f.3), which owns the machine driver callback.
- codec_dai->dev is the I2C device of the rt5660 codec itself
(i2c-10EC5660:00).
Since hw_params is a machine driver operation and both calls are made
within the same function from the machine driver's context, all error
messages should be attributed to rtd->dev. Using codec_dai->dev for one
of them would suggest the error originates inside the codec driver,
which is misleading.
Align the PLL error log with the sysclk one to use rtd->dev, matching
the convention used by all other Intel board drivers in this directory.
Signed-off-by: Sachin Mokashi <sachin.mokashi@intel.com>
Link: https://patch.msgid.link/20260327131439.1330373-1-sachin.mokashi@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'fs/devfs/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
