diff options
| author | Kuba Piecuch <jpiecuch@google.com> | 2026-07-10 14:43:41 +0000 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2026-07-10 06:41:28 -1000 |
| commit | 0e2f4ab68a89fad42e0f5a9ff4b740738e7aa1d6 (patch) | |
| tree | be6a02c0f2e29fe953ced4a16af01dcb0d26b90d /drivers/gpu/nova-core/fsp/git@git.tavy.me:linux.git | |
| parent | e6979d05c6a6fe79980f08d63f039f0b27c30a1c (diff) | |
sched_ext: Skip ops.set_weight() for disabled tasks
When switching a task's sched_class away from sched_ext, we get the
following sequence of events in __sched_setscheduler():
sched_change_begin()
switched_from_scx()
scx_disable_task(p)
ops.disable(p)
__setscheduler_params()
set_load_weight()
reweight_task_scx(p)
ops.set_weight(p)
p->sched_class = next_class;
sched_change_end()
...
Notably, ops.set_weight() is called _after_ ops.disable().
This violates the expected semantics of the callbacks, the expectation
being that ops.disable() can only be followed by ops.exit_task() or
ops.enable().
Skipping the weight adjustment for disabled tasks should be harmless
since the weight will be recalculated in scx_enable_task() if the task
ever rejoins SCX.
Fixes: 637b0682821b ("sched: Fold sched_class::switch{ing,ed}_{to,from}() into the change pattern")
Cc: stable@vger.kernel.org # v6.19+
Signed-off-by: Kuba Piecuch <jpiecuch@google.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/gpu/nova-core/fsp/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
