diff options
| author | Michal Grzedzicki <mge@meta.com> | 2026-03-30 09:06:44 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2026-04-07 19:43:50 +0200 |
| commit | 3cd181cc46d36aa7bd4af85f14639d86a25beaec (patch) | |
| tree | 66cb6bdf632e4d7208d60697a66bc371e2deee41 /Documentation/controllers/git@git.tavy.me:linux.git | |
| parent | e0dfaebb8f4a1de59a8b805d600e3b662b235efc (diff) | |
btrfs: fix silent IO error loss in encoded writes and zoned split
can_finish_ordered_extent() and btrfs_finish_ordered_zoned() set
BTRFS_ORDERED_IOERR via bare set_bit(). Later,
btrfs_mark_ordered_extent_error() in btrfs_finish_one_ordered() uses
test_and_set_bit(), finds it already set, and skips
mapping_set_error(). The error is never recorded on the inode's
address_space, making it invisible to fsync. For encoded writes this
causes btrfs receive to silently produce files with zero-filled holes.
Fix: replace bare set_bit(BTRFS_ORDERED_IOERR) with
btrfs_mark_ordered_extent_error() which pairs test_and_set_bit() with
mapping_set_error(), guaranteeing the error is recorded exactly once.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Mark Harmstone <mark@harmstone.com>
Signed-off-by: Michal Grzedzicki <mge@meta.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'Documentation/controllers/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
