diff options
| author | zhidao su <soolaugust@gmail.com> | 2026-03-04 13:37:30 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2026-03-04 07:01:18 -1000 |
| commit | 7a8464555d2e5f038758bb19e72ab4710b79e9cd (patch) | |
| tree | 68210a5e906bff3f97e19948df013ae52ff59b0a /Documentation/console/git@git.tavy.me:linux.git | |
| parent | 0031c06807cfa8aa51a759ff8aa09e1aa48149af (diff) | |
sched_ext: Use WRITE_ONCE() for the write side of dsq->seq update
bpf_iter_scx_dsq_new() reads dsq->seq via READ_ONCE() without holding
any lock, making dsq->seq a lock-free concurrently accessed variable.
However, dispatch_enqueue(), the sole writer of dsq->seq, uses a plain
increment without the matching WRITE_ONCE() on the write side:
dsq->seq++;
^^^^^^^^^^^
plain write -- KCSAN data race
The KCSAN documentation requires that if one accessor uses READ_ONCE()
or WRITE_ONCE() on a variable to annotate lock-free access, all other
accesses must also use the appropriate accessor. A plain write leaves
the pair incomplete and will trigger KCSAN warnings.
Fix by using WRITE_ONCE() for the write side of the update:
WRITE_ONCE(dsq->seq, dsq->seq + 1);
This is consistent with bpf_iter_scx_dsq_new() and makes the
concurrent access annotation complete and KCSAN-clean.
Signed-off-by: zhidao su <suzhidao@xiaomi.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'Documentation/console/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
