diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2026-03-11 21:29:14 +0100 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2026-03-12 11:29:15 +0100 |
| commit | f1cac6ac62d28a9a57b17f51ac5795bf250c12d3 (patch) | |
| tree | 1e40e5471093ef77e5f51c388972290c7da31556 /Documentation/cgroups/git@git.tavy.me:linux.git | |
| parent | 8d5fae6011260de209aaf231120e8146b14bc8e0 (diff) | |
x86/perf: Make sure to program the counter value for stopped events on migration
Both Mi Dapeng and Ian Rogers noted that not everything that sets HES_STOPPED
is required to EF_UPDATE. Specifically the 'step 1' loop of rescheduling
explicitly does EF_UPDATE to ensure the counter value is read.
However, then 'step 2' simply leaves the new counter uninitialized when
HES_STOPPED, even though, as noted above, the thing that stopped them might not
be aware it needs to EF_RELOAD -- since it didn't EF_UPDATE on stop.
One such location that is affected is throttling, throttle does pmu->stop(, 0);
and unthrottle does pmu->start(, 0); possibly restarting an uninitialized counter.
Fixes: a4eaf7f14675 ("perf: Rework the PMU methods")
Reported-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reported-by: Ian Rogers <irogers@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://patch.msgid.link/20260311204035.GX606826@noisy.programming.kicks-ass.net
Diffstat (limited to 'Documentation/cgroups/git@git.tavy.me:linux.git')
0 files changed, 0 insertions, 0 deletions
