summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Zhang <18255117159@163.com>2026-05-02 00:10:10 +0800
committerManivannan Sadhasivam <mani@kernel.org>2026-05-15 22:43:08 +0530
commitf02459d0342f94fbbc6296fca0f221783d3a37de (patch)
tree5e70ee0bdb493dc309c2d2141ae51f2f1fc86c12
parenta8bf471f87f4c5c180641a2c6f7d82b1aa0f61fd (diff)
PCI: keembay: Use common mode field in struct dw_pcie
Remove the redundant mode field from struct keembay_pcie and use the existing mode field in struct dw_pcie instead. This avoids duplication and prevents potential inconsistencies between the two mode fields. Signed-off-by: Hans Zhang <18255117159@163.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com> Link: https://patch.msgid.link/20260501161010.71688-5-18255117159@163.com
-rw-r--r--drivers/pci/controller/dwc/pcie-keembay.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/pci/controller/dwc/pcie-keembay.c b/drivers/pci/controller/dwc/pcie-keembay.c
index 7cf2c312ecec..2459c4d66b88 100644
--- a/drivers/pci/controller/dwc/pcie-keembay.c
+++ b/drivers/pci/controller/dwc/pcie-keembay.c
@@ -58,7 +58,6 @@
struct keembay_pcie {
struct dw_pcie pci;
void __iomem *apb_base;
- enum dw_pcie_device_mode mode;
struct clk *clk_master;
struct clk *clk_aux;
@@ -117,7 +116,7 @@ static int keembay_pcie_start_link(struct dw_pcie *pci)
u32 val;
int ret;
- if (pcie->mode == DW_PCIE_EP_TYPE)
+ if (pcie->pci.mode == DW_PCIE_EP_TYPE)
return 0;
keembay_pcie_ltssm_set(pcie, false);
@@ -409,7 +408,7 @@ static int keembay_pcie_probe(struct platform_device *pdev)
pci->dev = dev;
pci->ops = &keembay_pcie_ops;
- pcie->mode = mode;
+ pcie->pci.mode = mode;
pcie->apb_base = devm_platform_ioremap_resource_byname(pdev, "apb");
if (IS_ERR(pcie->apb_base))
@@ -417,7 +416,7 @@ static int keembay_pcie_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pcie);
- switch (pcie->mode) {
+ switch (pcie->pci.mode) {
case DW_PCIE_RC_TYPE:
if (!IS_ENABLED(CONFIG_PCIE_KEEMBAY_HOST))
return -ENODEV;
@@ -443,7 +442,7 @@ static int keembay_pcie_probe(struct platform_device *pdev)
break;
default:
- dev_err(dev, "Invalid device type %d\n", pcie->mode);
+ dev_err(dev, "Invalid device type %d\n", pcie->pci.mode);
return -ENODEV;
}