diff options
| author | bui duc phuc <phucduc.bui@gmail.com> | 2026-07-29 17:00:18 +0700 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-07-30 19:26:45 +0100 |
| commit | e95a0a309ca02bf26dc937cdeb3fe2a235c65f63 (patch) | |
| tree | feba3c78cd2ffa2b42800dcf3c923ac71bcc07db | |
| parent | 623d9a55685c52b10b995d8dbde9da6283170220 (diff) | |
regulator: rt6245: Restore state on enable failure
Currently, if regcache_sync() fails after the enable GPIO has been
asserted, the driver returns with enable_gpio still set high and
regcache_cache_only() left disabled. This leaves the device state
inconsistent with the disabled state, where the enable GPIO is low and
cache_only is enabled.
On failure, restore the original state by setting cache_only back to
true and driving the enable GPIO low before returning the error.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260729100018.66577-1-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/rt6245-regulator.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/regulator/rt6245-regulator.c b/drivers/regulator/rt6245-regulator.c index 1843ecec1922..5c0ee04e97ac 100644 --- a/drivers/regulator/rt6245-regulator.c +++ b/drivers/regulator/rt6245-regulator.c @@ -49,8 +49,11 @@ static int rt6245_enable(struct regulator_dev *rdev) regcache_cache_only(regmap, false); ret = regcache_sync(regmap); - if (ret) + if (ret) { + regcache_cache_only(regmap, true); + gpiod_direction_output(priv->enable_gpio, 0); return ret; + } priv->enable_state = true; return 0; |