diff options
| author | Maxime Chevallier <maxime.chevallier@bootlin.com> | 2026-04-28 14:58:27 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-04-29 17:30:05 -0700 |
| commit | e2d217fe3ff2a73ace0dbfe41b620c7fb767b000 (patch) | |
| tree | 55a1c253d1df914b05af7f3056f92f39be93780d | |
| parent | 776059b70231bd235493d68ae77d12df65d8dfe7 (diff) | |
net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
When configuring the link parameters in forced mode for the AQR-105, the
Extended Next Page bit gets advertised for Multi-Gigabit modes.
This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This
contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as
the Extended Next Page advertising. This bit used to be marked as
reserved, but a proper define for it was added in :
commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")
Let's use it instead of the ADVERTISE_RESV definition, making the code
more self-documenting.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260428125827.238469-1-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/phy/aquantia/aquantia_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index 41f3676c7f1e..e95d391a6dc2 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev) vend |= MDIO_AN_VEND_PROV_1000BASET_HALF; break; case SPEED_2500: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); vend |= MDIO_AN_VEND_PROV_2500BASET_FULL; break; case SPEED_5000: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); vend |= MDIO_AN_VEND_PROV_5000BASET_FULL; break; case SPEED_10000: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); ctrl10 |= MDIO_AN_10GBT_CTRL_ADV10G; break; default: |