diff options
| author | Pan Chuang <panchuang@vivo.com> | 2026-07-22 11:43:31 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-07-30 16:58:40 +0200 |
| commit | d5760123484ba05767913cd03cc7588939ec27a5 (patch) | |
| tree | 272f095aed88f06f8c841fe184dfeb88d248f52d | |
| parent | 651bc1d066184338f03625715767f31c053c6302 (diff) | |
serial: mvebu-uart: Remove redundant dev_err()
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Link: https://patch.msgid.link/20260722034342.316755-4-panchuang@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/mvebu-uart.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index 8e52be2b34ea..33ea496c93b2 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -404,29 +404,21 @@ static int mvebu_uart_startup(struct uart_port *port) ret = devm_request_irq(port->dev, mvuart->irq[UART_IRQ_SUM], mvebu_uart_isr, port->irqflags, dev_name(port->dev), port); - if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_IRQ_SUM]); + if (ret) return ret; - } } else { /* New bindings with an IRQ for RX and TX (both UART) */ ret = devm_request_irq(port->dev, mvuart->irq[UART_RX_IRQ], mvebu_uart_rx_isr, port->irqflags, dev_name(port->dev), port); - if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_RX_IRQ]); + if (ret) return ret; - } ret = devm_request_irq(port->dev, mvuart->irq[UART_TX_IRQ], mvebu_uart_tx_isr, port->irqflags, dev_name(port->dev), port); if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_TX_IRQ]); devm_free_irq(port->dev, mvuart->irq[UART_RX_IRQ], port); return ret; |