diff options
| author | Yulin Lu <luyulin@eswincomputing.com> | 2026-04-13 15:00:33 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2026-05-10 17:23:41 +0530 |
| commit | c2cd08e8f150738515c8df415ad7ecfa3d38124a (patch) | |
| tree | d5d40af40ce009bf480909e813c34b28e7d7fe9b | |
| parent | 80305760d7a55b884fb9023c490b75568d1ea0b1 (diff) | |
phy: eswin: Fix incorrect error check in probe()
devm_ioremap() returns NULL on failure, not an ERR_PTR.
Using IS_ERR() to check the return value is incorrect.
Fix this by checking for NULL and returning -ENOMEM.
Fixes: 67ee9ccaa34a ("phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver")
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/linux-phy/adjNbuWoc1B-3Ok1@stanley.mountain/
Signed-off-by: Yulin Lu <luyulin@eswincomputing.com>
Link: https://patch.msgid.link/20260413070033.128-1-luyulin@eswincomputing.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/phy/eswin/phy-eic7700-sata.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/eswin/phy-eic7700-sata.c b/drivers/phy/eswin/phy-eic7700-sata.c index c33653d48daa..76774b9e391b 100644 --- a/drivers/phy/eswin/phy-eic7700-sata.c +++ b/drivers/phy/eswin/phy-eic7700-sata.c @@ -216,8 +216,8 @@ static int eic7700_sata_phy_probe(struct platform_device *pdev) return -ENOENT; regs = devm_ioremap(dev, res->start, resource_size(res)); - if (IS_ERR(regs)) - return PTR_ERR(regs); + if (!regs) + return -ENOMEM; sata_phy->regmap = devm_regmap_init_mmio (dev, regs, &eic7700_sata_phy_regmap_config); |