diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2026-08-09 15:49:10 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-08-10 09:00:05 -0700 |
| commit | 799ef16e4607ba9ebc7fa2ca7d984940481fb79a (patch) | |
| tree | c6d03cf948725d06bcd3f1ccac6b412a4f06d617 | |
| parent | 382a3cd59e24e452f94717bc9ccab053d634a48f (diff) | |
watchdog: apple: Constify some structures
'struct watchdog_ops' and 'struct watchdog_info' are not modified in this
driver.
Constifying these structure moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.
On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
7319 1768 0 9087 237f drivers/watchdog/apple_wdt.o
After:
=====
text data bss dec hex filename
7543 1544 0 9087 237f drivers/watchdog/apple_wdt.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/99019b7e560c2d9c087be340e68f9cce4db1988e.1786283336.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/watchdog/apple_wdt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c index 6b9b0f9b05ce..f533953294f6 100644 --- a/drivers/watchdog/apple_wdt.c +++ b/drivers/watchdog/apple_wdt.c @@ -139,7 +139,7 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode, return 0; } -static struct watchdog_ops apple_wdt_ops = { +static const struct watchdog_ops apple_wdt_ops = { .owner = THIS_MODULE, .start = apple_wdt_start, .stop = apple_wdt_stop, @@ -149,7 +149,7 @@ static struct watchdog_ops apple_wdt_ops = { .restart = apple_wdt_restart, }; -static struct watchdog_info apple_wdt_info = { +static const struct watchdog_info apple_wdt_info = { .identity = "Apple SoC Watchdog", .options = WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT, }; |