diff options
| author | Sven Eckelmann <sven@narfation.org> | 2026-07-03 20:28:31 +0200 |
|---|---|---|
| committer | Sven Eckelmann <sven@narfation.org> | 2026-07-06 07:18:59 +0200 |
| commit | 6b628425aed49a1c7a4ffc997583840fc582d32b (patch) | |
| tree | 50dd2beb26e80bf4557ebb5ab48c4e49ac85db7e | |
| parent | 7a581d9aaba8c82bd6177fa36b2588eea77f6e2b (diff) | |
batman-adv: frag: free unfragmentable packet
The caller of batadv_frag_send_packet() assume that the skb provided to the
function are always consumed. But the pre-check for an empty payload or the
zero fragment size returned an error without any further actions.
A failed pre-check must use the same error handling code as the rest of the
function.
Cc: stable@vger.kernel.org
Fixes: ee75ed88879a ("batman-adv: Fragment and send skbs larger than mtu")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
| -rw-r--r-- | net/batman-adv/fragmentation.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/batman-adv/fragmentation.c b/net/batman-adv/fragmentation.c index 8a006a0473a8..13d4689d332d 100644 --- a/net/batman-adv/fragmentation.c +++ b/net/batman-adv/fragmentation.c @@ -518,8 +518,10 @@ int batadv_frag_send_packet(struct sk_buff *skb, mtu = min_t(unsigned int, mtu, BATADV_FRAG_MAX_FRAG_SIZE); max_fragment_size = mtu - header_size; - if (skb->len == 0 || max_fragment_size == 0) - return -EINVAL; + if (skb->len == 0 || max_fragment_size == 0) { + ret = -EINVAL; + goto free_skb; + } num_fragments = (skb->len - 1) / max_fragment_size + 1; max_fragment_size = (skb->len - 1) / num_fragments + 1; |