diff options
| author | Kory Maincent (TI.com) <kory.maincent@bootlin.com> | 2026-01-23 17:12:38 +0100 |
|---|---|---|
| committer | Luca Ceresoli <luca.ceresoli@bootlin.com> | 2026-02-11 09:16:15 +0100 |
| commit | 1b47ea9fddcf89e4b65045d233bc5a2ee7775df7 (patch) | |
| tree | bbe9ce886838be4808d224e3d0f8771ef504b422 | |
| parent | 2c6f1b1fa78acd5f3bd80e3519b6b23907ea9c2f (diff) | |
drm/tilcdc: Use devm_drm_of_get_bridge() helper
Replace drm_of_find_panel_or_bridge() with the newer
devm_drm_of_get_bridge() helper which simplifies the code by:
- Automatically handling both panel and bridge cases internally
- Managing the panel-to-bridge conversion when needed
- Using devres for resource management, eliminating manual cleanup
This removes the need for explicit panel-to-bridge conversion via
devm_drm_panel_bridge_add_typed() and the associated error handling path.
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20260123-feature_tilcdc-v5-20-5a44d2aa3f6f@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
| -rw-r--r-- | drivers/gpu/drm/tilcdc/tilcdc_encoder.c | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c b/drivers/gpu/drm/tilcdc/tilcdc_encoder.c index a34a10337f6a..546fe7e6ee81 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_encoder.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_encoder.c @@ -55,15 +55,12 @@ int tilcdc_encoder_create(struct drm_device *ddev) struct tilcdc_drm_private *priv = ddev_to_tilcdc_priv(ddev); struct tilcdc_encoder *encoder; struct drm_bridge *bridge; - struct drm_panel *panel; - int ret; - ret = drm_of_find_panel_or_bridge(ddev->dev->of_node, 0, 0, - &panel, &bridge); - if (ret == -ENODEV) + bridge = devm_drm_of_get_bridge(ddev->dev, ddev->dev->of_node, 0, 0); + if (PTR_ERR(bridge) == -ENODEV) return 0; - else if (ret) - return ret; + else if (IS_ERR(bridge)) + return PTR_ERR(bridge); encoder = drmm_simple_encoder_alloc(ddev, struct tilcdc_encoder, base, DRM_MODE_ENCODER_NONE); @@ -73,12 +70,5 @@ int tilcdc_encoder_create(struct drm_device *ddev) } priv->encoder = encoder; - if (panel) { - bridge = devm_drm_panel_bridge_add_typed(ddev->dev, panel, - DRM_MODE_CONNECTOR_DPI); - if (IS_ERR(bridge)) - return PTR_ERR(bridge); - } - return tilcdc_attach_bridge(ddev, bridge); } |