diff options
| author | Maxime Ripard <mripard@kernel.org> | 2026-06-19 14:24:10 +0200 |
|---|---|---|
| committer | Maxime Ripard <mripard@kernel.org> | 2026-06-22 11:24:18 +0200 |
| commit | 16710bcb96405b71ff8b9ebcc0923707d4c61615 (patch) | |
| tree | 12066f3e858a3943e24cf80e06362cc53ebb7b5d | |
| parent | c8a25a2d855a62c37880d6cd02ce799d889ed973 (diff) | |
drm/atomic-state-helper: Drop memset from __drm_atomic_helper_bridge_state_init()
__drm_atomic_helper_bridge_state_init() is always called on a freshly
kzalloc-ed state, so the memset is redundant.
Drop it and document the expectation that the state is already zeroed.
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # imx8mp + sn65dsi84 + bridge hotplug
Link: https://patch.msgid.link/20260619-drm-no-more-bridge-reset-v3-5-ff399263111b@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
| -rw-r--r-- | drivers/gpu/drm/drm_atomic_state_helper.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index 8f04eae7a754..f0688f2d83fe 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -891,6 +891,8 @@ EXPORT_SYMBOL(drm_atomic_helper_bridge_destroy_state); * @state: bridge state to initialize * @bridge: the bridge this state refers to * + * @state is assumed to be zeroed. + * * Initializes the bridge state to default values. This is meant to be called * by the bridge &drm_bridge_funcs.atomic_reset hook for bridges that subclass * the bridge state. @@ -898,7 +900,6 @@ EXPORT_SYMBOL(drm_atomic_helper_bridge_destroy_state); void __drm_atomic_helper_bridge_state_init(struct drm_bridge_state *state, struct drm_bridge *bridge) { - memset(state, 0, sizeof(*state)); __drm_atomic_helper_private_obj_create_state(&bridge->base, &state->base); state->bridge = bridge; } |