diff options
| author | Luca Ceresoli <luca.ceresoli@bootlin.com> | 2026-04-07 14:24:23 +0200 |
|---|---|---|
| committer | Luca Ceresoli <luca.ceresoli@bootlin.com> | 2026-04-14 13:52:32 +0200 |
| commit | 1148ef0c600f641f4ea95b3d8275cc911fd2f232 (patch) | |
| tree | 36b4a1729e97ef2a35e3eb24603d68f7854c4d2e | |
| parent | 73cb588a6d90849301ef48ac89f3439a8942a890 (diff) | |
drm/bridge: imx8mp-hdmi-tx-connector-fixup: show a warning when adding the overlay
Describing the HDMI connector in device tree is recommended. While the
overlay insertion is a workaround to avoid breaking existing devices, every
dts should be improved by adding a connector description.
Add a warning to make users aware as far as possible.
As a warning line cannot hold all the relevant info, add a detailed comment
in the code so it easy to find when the warning is seen.
Reviewed-by: Liu Ying <victor.liu@nxp.com>
Link: https://patch.msgid.link/20260407-drm-lcdif-dbanc-v4-9-247a16e61ef9@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
| -rw-r--r-- | drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c index dc1736bfc3ac..aaac27d00590 100644 --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c @@ -44,6 +44,23 @@ static int __init imx8mp_hdmi_tx_connector_fixup_init(void) if (endpoint) return 0; + /* + * Boards with an HDMI connector should describe it in a device + * tree node with compatible = "hdmi-connector". + * + * If you see this warning, it means such a node was not found and + * a fallback one is added using a device tree overlay. Please add + * one in your device tree, also describing the exact connector + * type (the added overlay assumes Type A as a fallback, but it + * might be wrong). + * + * This node is necessary for modern DRM, where bridge drivers do + * not create a connector (see the DRM_BRIDGE_ATTACH_NO_CONNECTOR + * flag). See https://docs.kernel.org/gpu/drm-kms-helpers.html for + * more info. + */ + pr_warn("Please add a hdmi-connector DT node for imx8mp-hdmi-tx.\n"); + dtbo_start = __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; dtbo_size = __dtbo_imx8mp_hdmi_tx_connector_fixup_end - __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; |