summaryrefslogtreecommitdiff
path: root/samples/workqueue/stall_detector/git@git.tavy.me:linux-stable.git
diff options
context:
space:
mode:
authorZide Chen <zide.chen@intel.com>2026-03-13 10:40:49 -0700
committerPeter Zijlstra <peterz@infradead.org>2026-04-07 09:05:29 +0200
commita16d1ec4dd0cdcf689f324adde6067083bce9099 (patch)
treeb204dd95f0ed0322f0d071f379736e2e1d442f21 /samples/workqueue/stall_detector/git@git.tavy.me:linux-stable.git
parent7b568e9eba2fad89a696f22f0413d44cf4a1f892 (diff)
perf/x86/intel/uncore: Fix die ID init and look up bugs
In snbep_pci2phy_map_init(), in the nr_node_ids > 8 path, uncore_device_to_die() may return -1 when all CPUs associated with the UBOX device are offline. Remove the WARN_ON_ONCE(die_id == -1) check for two reasons: - The current code breaks out of the loop. This is incorrect because pci_get_device() does not guarantee iteration in domain or bus order, so additional UBOX devices may be skipped during the scan. - Returning -EINVAL is incorrect, since marking offline buses with die_id == -1 is expected and should not be treated as an error. Separately, when NUMA is disabled on a NUMA-capable platform, pcibus_to_node() returns NUMA_NO_NODE, causing uncore_device_to_die() to return -1 for all PCI devices. As a result, spr_update_device_location(), used on Intel SPR and EMR, ignores the corresponding PMON units and does not add them to the RB tree. Fix this by using uncore_pcibus_to_dieid(), which retrieves topology from the UBOX GIDNIDMAP register and works regardless of whether NUMA is enabled in Linux. This requires snbep_pci2phy_map_init() to be added in spr_uncore_pci_init(). Keep uncore_device_to_die() only for the nr_node_ids > 8 case, where NUMA is expected to be enabled. Fixes: 9a7832ce3d92 ("perf/x86/intel/uncore: With > 8 nodes, get pci bus die id from NUMA info") Fixes: 65248a9a9ee1 ("perf/x86/uncore: Add a quirk for UPI on SPR") Signed-off-by: Zide Chen <zide.chen@intel.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com> Tested-by: Steve Wahl <steve.wahl@hpe.com> Link: https://patch.msgid.link/20260313174050.171704-4-zide.chen@intel.com
Diffstat (limited to 'samples/workqueue/stall_detector/git@git.tavy.me:linux-stable.git')
0 files changed, 0 insertions, 0 deletions