diff options
| author | Johan Hovold <johan@kernel.org> | 2026-06-23 17:12:29 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2026-06-29 08:52:34 +0200 |
| commit | 24ca1fea8f2753bf33e1d458ec1ae5d9b7796a65 (patch) | |
| tree | 546ea5d28ba0f1823fe3f03aee02a956d80ba1af /rust/zerocopy/git@git.tavy.me:linux-stable.git | |
| parent | ab9de95c9cf952332ab79453b4b5d1bfca8e514f (diff) | |
USB: serial: digi_acceleport: fix write buffer corruption
The digi_write_inb_command() is supposed to wait for the write urb to
become available or return an error, but instead it updates the transfer
buffer and tries to resubmit the urb on timeout.
To make things worse, for commands like break control where no timeout
is used, the driver would corrupt the urb immediately due to a broken
jiffies comparison (on 32-bit machines this takes five minutes of uptime
to trigger due to INITIAL_JIFFIES).
Fix this by adding the missing return on timeout and waiting
indefinitely when no timeout has been specified as intended.
This issue was (sort of) flagged by Sashiko when reviewing an unrelated
change to the driver.
Link: https://sashiko.dev/#/patchset/20260610132232.356139-1-johan%40kernel.org?part=11
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'rust/zerocopy/git@git.tavy.me:linux-stable.git')
0 files changed, 0 insertions, 0 deletions
