diff options
| author | Marius Bergmann <marius@mtbit.de> | 2019-11-06 00:19:08 +0100 |
|---|---|---|
| committer | Marius Bergmann <marius@mtbit.de> | 2019-11-08 23:41:08 +0100 |
| commit | 3ddd53e57618ac45c5e78e530c688e77fd459b8d (patch) | |
| tree | c48db4d65e76a2db270fe8b7db502a69cf7f487e /pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch | |
| parent | 206f71904644e692f1dfb22fac23f77f951148b5 (diff) | |
terraform-providers: fix handling of version/rev in provider list
I interpreted the purpose of stripping the first character from the 'version'
argument as an attempt to remove a prefixed 'v' (e.g. 'v1.0.0') from a version
tag. This works if the tag actually has a 'v' prefix, but also removes the first
character if version tags are not prefixed (e.g. '1.0.0').
Additionally, the 'v' was added again when specifying the `rev` for
`fetchFromGitHub` in default.nix. As described above, this did also not work
when provider repos did not prefix their version tags with 'v'.
I changed the implementation as follows:
- `version` and `rev` are stored inside data.nix
- `version` is used to declare the nix package version
- `rev` is used to fetch the proper git ref when building the package
- for determining `version`, an optional leading 'v' is trimmed from the tag
name
Now this has the implication that the latest tag must always be a release tag
when using the `update-all` script, but as the result of running `update-all`
should always be reviewed before submission, makes this appear a manageable
tradeoff to me.
Diffstat (limited to 'pkgs/development/python-modules/python-mapnik/python-mapnik_std_optional.patch')
0 files changed, 0 insertions, 0 deletions
