diff options
| author | aszlig <aszlig@nix.build> | 2018-09-26 16:15:50 +0200 |
|---|---|---|
| committer | aszlig <aszlig@nix.build> | 2018-09-26 16:17:18 +0200 |
| commit | 593062ddc2104cf91b1cf9cc0e4f4b1437f59f6b (patch) | |
| tree | d5a20fed3e362e2923bc5d74419f7ce0ce21b57f /pkgs/development/python-modules/GitPython/hardcode-git-path.patch | |
| parent | ca3231a9f33e7596eb7d6422e4239d8a3a505db0 (diff) | |
fetchFromGitLab: Fix grouping issue for group arg
Issue introduced by c3612b97e625ad0d70c6ba56d191bcb9a403f44c.
Example output before that commit (witch a random package using
fetchFromGitLab):
$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/hsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]
After the commit:
$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/%2Fhsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]
And with this very commit, which fixes the issue:
$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/hsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]
The problem was that it has used optionalString in conjunction with "+",
so the optionalString only applied to the left-hand side of the +
operator.
Thanks to @ryantm for reporting the issue at:
https://github.com/NixOS/nixpkgs/pull/46487/commits/c3612b97e625ad0d70c6ba56d191bcb9a403f44c#r220576764
Signed-off-by: aszlig <aszlig@nix.build>
Reported-by: Ryan Mulligan <ryan@ryantm.com>
Diffstat (limited to 'pkgs/development/python-modules/GitPython/hardcode-git-path.patch')
0 files changed, 0 insertions, 0 deletions