diff options
| author | Wolfgang Walther <walther@technowledgy.de> | 2025-07-18 09:23:17 +0200 |
|---|---|---|
| committer | github-actions[bot] <github-actions[bot]@users.noreply.github.com> | 2026-01-18 21:05:20 +0000 |
| commit | 6d0a1f3ee02082555cd4a8690059bd03c1a063aa (patch) | |
| tree | e65d7b7a24b546c5868865ab35e529ace52133a1 | |
| parent | 4d2b249a94fd32c0d09046c37e80b83a1c5cb1fc (diff) | |
.github/PULL_REQUEST_TEMPLATE: remove +1 footer
The footer has the following problems:
- It's not consistently added in all PRs, for example backports or those
where the template is not used. Inconsistency in a voting skews the
results.
- It's arguably not effective, because people use reactions naturally to
interact with PRs anyway. As long as there are multiple different
reaction types, what does it mean that one PR has 20 :+1:, but another
has 22 :tada:? The latter won't show up in the ranking for :+1:, so at
the minimum confusing. Same for :heart:.
- It's not useful to determine priority as in "higher number of votes
should be merged". A PR's quality should be determined independently of
votes - when it's good, it will be merged. The currently most upvoted PR
has serious issues, so this invites drive-by questions like "Why isn't
this merged, given the number of upvotes?".
(cherry picked from commit c89c90dfa137316f3cf662783b4795d8b9897237)
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 85561029c86a..45a55eb45dce 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -38,10 +38,3 @@ For new packages please briefly describe the package or provide a link to its ho [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test - ---- - -Add a :+1: [reaction] to [pull requests you find important]. - -[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ -[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc |