Path interpolation syntax is not supported in the minimum nix version.
also: manual: differences in makeWrapper implementations better explained Update pkgs/by-name/ma/makeBinaryWrapper/make-binary-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/by-name/ma/makeBinaryWrapper/make-binary-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/by-name/ma/makeBinaryWrapper/make-binary-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/build-support/setup-hooks/make-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/build-support/setup-hooks/make-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/build-support/setup-hooks/make-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/by-name/ma/makeBinaryWrapper/make-binary-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/build-support/setup-hooks/make-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/by-name/ma/makeBinaryWrapper/make-binary-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li> Update pkgs/build-support/setup-hooks/make-wrapper.sh Co-authored-by: Naïm Camille Favier <n@monade.li>
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build https://github.com/infinisil/treewide-nixpkgs-reformat-script/archive/a08b3a4d199c6124ac5b36a889d9099b4383463f.tar.gz \
--argstr baseRev b32a0943687d2a5094a6d92f25a4b6e16a76b5b7
result/bin/apply-formatting $NIXPKGS_PATH
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
The source included way more files than it really needed. This commit limits it to exactly those it needs. This also makes sure that no rebuild is necessary when any Nix file changes, in particular useful when we reformat the Nix files.
We shouldn't try compiling to aarch64-unknown-linux-gnu from aarch64-unknown-linux-gnu, because that tends to confuse things and is not representative of actual cross compilation usage.