From bbc23003e00517144ce65901e5f74ea2c0ceb5d3 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Wed, 3 Jun 2026 18:14:34 +0300 Subject: drm/i915/color: deduplicate loops in xelpd_program_plane_pre_csc_lut() Now that the pre_csc_lut and non-pre_csc_lut paths look similar, deduplicate the loops and just determine the value based on pre_csc_lut vs. not. Reviewed-by: Chaitanya Kumar Borah Link: https://patch.msgid.link/b943121a358dab0b04c9766baba8295f12ae53fc.1780499355.git.jani.nikula@intel.com Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index 5c09c5dd361e..d705f745bd7d 100644 --- a/drivers/gpu/drm/i915/display/intel_color.c +++ b/drivers/gpu/drm/i915/display/intel_color.c @@ -3977,27 +3977,21 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb, PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0), PLANE_PAL_PREC_AUTO_INCREMENT); - if (pre_csc_lut) { - for (i = 0; i < lut_size + 3; i++) { + for (i = 0; i < lut_size + 3; i++) { + if (pre_csc_lut) { if (i < lut_size) lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24); /* else duplicate last lut_val */ - - intel_de_write_dsb(display, dsb, - PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0), - lut_val); - } - } else { - for (i = 0; i < lut_size + 3; i++) { + } else { if (i < lut_size) lut_val = (i * ((1 << 24) - 1)) / (lut_size - 1); else lut_val = 1 << 24; - - intel_de_write_dsb(display, dsb, - PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0), - lut_val); } + + intel_de_write_dsb(display, dsb, + PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0), + lut_val); } intel_de_write_dsb(display, dsb, PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0), 0); -- cgit v1.2.3