linux.git/tools, branch v5.5-rc4

rseq/selftests: Clarify rseq_prepare_unload() helper requirements

2019-12-23T17:52:41+00:00

The rseq.h UAPI now documents that the rseq_cs field must be cleared
before reclaiming memory that contains the targeted struct rseq_cs, but
also that the rseq_cs field must be cleared before reclaiming memory of
the code pointed to by the rseq_cs start_ip and post_commit_offset
fields.

While we can expect that use of dlclose(3) will typically unmap
both struct rseq_cs and its associated code at once, nothing would
theoretically prevent a JIT from reclaiming the code without
reclaiming the struct rseq_cs, which would erroneously allow the
kernel to consider new code which is not a rseq critical section
as a rseq critical section following a code reclaim.

Suggested-by: Florian Weimer 
Signed-off-by: Mathieu Desnoyers 
Cc: Shuah Khan 
Cc: Florian Weimer 
Cc: Thomas Gleixner 
Cc: Peter Zijlstra (Intel) 
Cc: "Paul E. McKenney" 
Cc: Boqun Feng 
Cc: "H . Peter Anvin" 
Cc: Paul Turner 
Cc: Dmitry Vyukov 
Signed-off-by: Shuah Khan

rseq/selftests: Fix: Namespace gettid() for compatibility with glibc 2.30

2019-12-23T17:52:41+00:00

glibc 2.30 introduces gettid() in public headers, which clashes with
the internal static definition within rseq selftests.

Rename gettid() to rseq_gettid() to eliminate this symbol name clash.

Reported-by: Tommi T. Rantala 
Signed-off-by: Mathieu Desnoyers 
Cc: Shuah Khan 
Cc: Tommi T. Rantala 
Cc: Thomas Gleixner 
Cc: Peter Zijlstra (Intel) 
Cc: "Paul E. McKenney" 
Cc: Boqun Feng 
Cc: "H . Peter Anvin" 
Cc: Paul Turner 
Cc: Dmitry Vyukov 
Cc: 	# v4.18+
Signed-off-by: Shuah Khan

rseq/selftests: Turn off timeout setting

2019-12-23T17:52:41+00:00

As the rseq selftests can run for a long period of time, disable the
timeout that the general selftests have.

Signed-off-by: Mathieu Desnoyers 
Cc: Shuah Khan 
Cc: Thomas Gleixner 
Cc: Peter Zijlstra (Intel) 
Cc: "Paul E. McKenney" 
Cc: Boqun Feng 
Cc: "H . Peter Anvin" 
Cc: Paul Turner 
Cc: Dmitry Vyukov 
Signed-off-by: Shuah Khan

kunit/kunit_tool_test: Test '--build_dir' option run

2019-12-23T17:52:41+00:00

This commit adds kunit tool test for the '--build_dir' option.

Signed-off-by: SeongJae Park 
Reviewed-by: Brendan Higgins 
Tested-by: Brendan Higgins 
Signed-off-by: Shuah Khan

kunit: Rename 'kunitconfig' to '.kunitconfig'

2019-12-23T17:52:41+00:00

This commit renames 'kunitconfig' to '.kunitconfig' so that it can be
automatically ignored by git and do not disturb people who want to type
'kernel/' by pressing only the 'k' and then 'tab' key.

Signed-off-by: SeongJae Park 
Reviewed-by: Brendan Higgins 
Tested-by: Brendan Higgins 
Signed-off-by: Shuah Khan

kunit: Place 'test.log' under the 'build_dir'

2019-12-23T17:52:41+00:00

'kunit' writes the 'test.log' under the kernel source directory even
though a 'build_dir' option is given.  As users who use the option might
expect the outputs to be placed under the specified directory, this
commit modifies the logic to write the log file under the 'build_dir'.

Signed-off-by: SeongJae Park 
Reviewed-by: Brendan Higgins 
Tested-by: Brendan Higgins 
Signed-off-by: Shuah Khan

kunit: Create default config in '--build_dir'

2019-12-23T17:52:41+00:00

If both '--build_dir' and '--defconfig' are given, the handling of
'--defconfig' ignores '--build_dir' option.  This commit modifies the
behavior to respect '--build_dir' option.

Reported-by: Brendan Higgins 
Suggested-by: Brendan Higgins 
Signed-off-by: SeongJae Park 
Reviewed-by: Brendan Higgins 
Tested-by: Brendan Higgins 
Signed-off-by: Shuah Khan

kunit: Remove duplicated defconfig creation

2019-12-23T17:52:40+00:00

'--defconfig' option is handled by the 'main() of the 'kunit.py' but
again handled in following 'run_tests()'.  This commit removes this
duplicated handling of the option in the 'run_tests()'.

Signed-off-by: SeongJae Park 
Reviewed-by: Brendan Higgins 
Tested-by: Brendan Higgins 
Signed-off-by: Shuah Khan

selftests: livepatch: Fix it to do root uid check and skip

2019-12-23T17:52:40+00:00

livepatch test configures the system and debug environment to run
tests. Some of these actions fail without root access and test
dumps several permission denied messages before it exits.

Fix test-state.sh to call setup_config instead of set_dynamic_debug
as suggested by Petr Mladek 

Fix it to check root uid and exit with skip code instead.

Signed-off-by: Shuah Khan 
Acked-by: Joe Lawrence 
Reviewed-by: Petr Mladek 
Signed-off-by: Shuah Khan

selftests: firmware: Fix it to do root uid check and skip

2019-12-23T17:52:40+00:00

firmware attempts to load test modules that require root access
and fail. Fix it to check for root uid and exit with skip code
instead.

Before this fix:

selftests: firmware: fw_run_tests.sh
modprobe: ERROR: could not insert 'test_firmware': Operation not permitted
You must have the following enabled in your kernel:
CONFIG_TEST_FIRMWARE=y
CONFIG_FW_LOADER=y
CONFIG_FW_LOADER_USER_HELPER=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
not ok 1 selftests: firmware: fw_run_tests.sh # SKIP

With this fix:

selftests: firmware: fw_run_tests.sh
skip all tests: must be run as root
not ok 1 selftests: firmware: fw_run_tests.sh # SKIP

Signed-off-by: Shuah Khan 
Reviwed-by: Greg Kroah-Hartman 
Signed-off-by: Shuah Khan