linux.git/tools/testing/selftests/x86/test_vsyscall.c, branch vsnprintf

selftests/x86: fix printk warnings reported by clang

2024-07-11T17:23:55+00:00

These warnings are all of the form, "the format specified a short
(signed or unsigned) int, but the value is a full length int".

Acked-by: Muhammad Usama Anjum 
Signed-off-by: John Hubbard 
Signed-off-by: Shuah Khan

selftests/x86: remove (or use) unused variables and functions

2024-07-11T17:23:55+00:00

When building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...quite a few functions are variables are generating "unused" warnings.
Fix the warnings by deleting the unused items.

One item, the "nerrs" variable in vsdo_restorer.c's main(), is unused
but probably wants to be returned from main(), as a non-zero result.
That result is also unused right now, so another option would be to
delete it entirely, but this way, main() also gets fixed. It was missing
a return value.

Acked-by: Muhammad Usama Anjum 
Signed-off-by: John Hubbard 
Signed-off-by: Shuah Khan

selftests: x86: test_vsyscall: conform test to TAP format output

2024-05-06T19:57:19+00:00

Conform the layout, informational and status messages to TAP. No
functional change is intended other than the layout of output messages.
Add more logic code to skip the tests if particular configuration isn't
available to make sure that either we skip each test or mark it pass/fail.

Signed-off-by: Muhammad Usama Anjum 
Signed-off-by: Shuah Khan

selftests: x86: test_vsyscall: reorder code to reduce #ifdef blocks

2024-05-06T19:57:19+00:00

There are multiple #ifdef blocks inside functions where they return just
0 if #ifdef is false. This makes number of tests counting difficult.
Move those functions inside one #ifdef block and move all of them
together. This is preparatory patch for next patch to convert this into
TAP format. So in this patch, we are just moving functions around
without any changes.

With and without this patch, the output of this patch is same.

Signed-off-by: Muhammad Usama Anjum 
Signed-off-by: Shuah Khan

selftests: Emit a warning if getcpu() is missing on 32bit

2023-02-06T14:48:54+00:00

The VDSO implementation for getcpu() has been wired up on 32bit so warn if
missing.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Thomas Gleixner 
Acked-by: Shuah Khan 
Link: https://lore.kernel.org/r/20221125094216.3663444-4-bigeasy@linutronix.de

selftests: x86: fix [-Wstringop-overread] warn in test_process_vm_readv()

2021-10-25T15:27:20+00:00

Fix the following [-Wstringop-overread] by passing in the variable
instead of the value.

test_vsyscall.c: In function ‘test_process_vm_readv’:
test_vsyscall.c:500:22: warning: ‘__builtin_memcmp_eq’ specified bound 4096 exceeds source size 0 [-Wstringop-overread]
  500 |                 if (!memcmp(buf, (const void *)0xffffffffff600000, 4096)) {
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shuah Khan

selftests/x86/test_vsyscall: Improve the process_vm_readv() test

2020-09-04T01:36:55+00:00

The existing code accepted process_vm_readv() success or failure as long
as it didn't return garbage.  This is too weak: if the vsyscall page is
readable, then process_vm_readv() should succeed and, if the page is not
readable, then it should fail.

Signed-off-by: Andy Lutomirski 
Signed-off-by: Dave Hansen 
Cc: x86@kernel.org
Cc: Peter Zijlstra 
Cc: Andy Lutomirski 
Cc: Jann Horn 
Cc: John Hubbard 
Cc: Andrew Morton 
Cc: Kirill A. Shutemov 
Signed-off-by: Linus Torvalds

selftests/x86: Consolidate and fix get/set_eflags() helpers

2020-07-01T08:00:27+00:00

There are several copies of get_eflags() and set_eflags() and they all are
buggy.  Consolidate them and fix them.  The fixes are:

Add memory clobbers.  These are probably unnecessary but they make sure
that the compiler doesn't move something past one of these calls when it
shouldn't.

Respect the redzone on x86_64.  There has no failure been observed related
to this, but it's definitely a bug.

Signed-off-by: Andy Lutomirski 
Signed-off-by: Thomas Gleixner 
Link: https://lkml.kernel.org/r/982ce58ae8dea2f1e57093ee894760e35267e751.1593191971.git.luto@kernel.org

selftests/x86: fix spelling mistake "FAILT" -> "FAIL"

2019-07-23T16:45:15+00:00

There is an spelling mistake in an a test error message. Fix it.

Acked-by: Andy Lutomirski 
Signed-off-by: Colin Ian King 
Signed-off-by: Shuah Khan

selftests/x86: Add a test for process_vm_readv() on the vsyscall page

2019-06-27T22:04:40+00:00

get_gate_page() is a piece of somewhat alarming code to make
get_user_pages() work on the vsyscall page.  Test it via
process_vm_readv().

Signed-off-by: Andy Lutomirski 
Signed-off-by: Thomas Gleixner 
Reviewed-by: Kees Cook 
Cc: Florian Weimer 
Cc: Jann Horn 
Cc: Borislav Petkov 
Cc: Kernel Hardening 
Cc: Peter Zijlstra 
Link: https://lkml.kernel.org/r/0fe34229a9330e8f9de9765967939cc4f1cf26b1.1561610354.git.luto@kernel.org