linux.git/tools/testing/selftests/tc-testing, branch v6.4-rc2

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2023-04-26T08:17:46+00:00

No conflicts.

Signed-off-by: Paolo Abeni

selftests: tc-testing: add more tests for sch_qfq

2023-04-23T17:47:09+00:00

The QFQ qdisc class has parameter bounds that are not being
checked for correctness.

Acked-by: Jamal Hadi Salim 
Signed-off-by: Pedro Tammela 
Signed-off-by: David S. Miller

net/sched: sch_fq: fix integer overflow of "credit"

2023-04-22T03:24:29+00:00

if sch_fq is configured with "initial quantum" having values greater than
INT_MAX, the first assignment of "credit" does signed integer overflow to
a very negative value.
In this situation, the syzkaller script provided by Cristoph triggers the
CPU soft-lockup warning even with few sockets. It's not an infinite loop,
but "credit" wasn't probably meant to be minus 2Gb for each new flow.
Capping "initial quantum" to INT_MAX proved to fix the issue.

v2: validation of "initial quantum" is done in fq_policy, instead of open
    coding in fq_change() _ suggested by Jakub Kicinski

Reported-by: Christoph Paasch 
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/377
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Reviewed-by: Eric Dumazet 
Signed-off-by: Davide Caratti 
Link: https://lore.kernel.org/r/7b3a3c7e36d03068707a021760a194a8eb5ad41a.1682002300.git.dcaratti@redhat.com
Signed-off-by: Jakub Kicinski

selftests: tc-testing: add tunnel_key "nofrag" test case

2023-03-31T06:24:24+00:00

# ./tdc.py -e 6bda -l
 6bda: (actions, tunnel_key) Add tunnel_key action with nofrag option

Acked-by: Jamal Hadi Salim 
Signed-off-by: Davide Caratti 
Signed-off-by: Jakub Kicinski

selftests: tc-testing: add "depends_on" property to skip tests

2023-03-31T06:24:24+00:00

currently, users can skip individual test cases by means of writing

  "skip": "yes"

in the scenario file. Extend this functionality, introducing 'dependsOn':
it's optional property like "skip", but the value contains a command (for
example, a probe on iproute2 to check if it supports a specific feature).
If such property is present, tdc executes that command and skips the test
when the return value is non-zero.

Reviewed-by: Pedro Tammela 
Signed-off-by: Davide Caratti 
Signed-off-by: Jakub Kicinski

selftests: tc-testing: add tests for action binding

2023-03-13T23:54:16+00:00

Add tests that check if filters can bind actions, that is create an
action independently and then bind to a filter.

tdc-tests under category 'infra':
1..18
ok 1 abdc - Reference pedit action object in filter
ok 2 7a70 - Reference mpls action object in filter
ok 3 d241 - Reference bpf action object in filter
ok 4 383a - Reference connmark action object in filter
ok 5 c619 - Reference csum action object in filter
ok 6 a93d - Reference ct action object in filter
ok 7 8bb5 - Reference ctinfo action object in filter
ok 8 2241 - Reference gact action object in filter
ok 9 35e9 - Reference gate action object in filter
ok 10 b22e - Reference ife action object in filter
ok 11 ef74 - Reference mirred action object in filter
ok 12 2c81 - Reference nat action object in filter
ok 13 ac9d - Reference police action object in filter
ok 14 68be - Reference sample action object in filter
ok 15 cf01 - Reference skbedit action object in filter
ok 16 c109 - Reference skbmod action object in filter
ok 17 4abc - Reference tunnel_key action object in filter
ok 18 dadd - Reference vlan action object in filter

Reviewed-by: Jamal Hadi Salim 
Signed-off-by: Pedro Tammela 
Link: https://lore.kernel.org/r/20230309175554.304824-1-pctammela@mojatatu.com
Signed-off-by: Jakub Kicinski

net/sched: Retire rsvp classifier

2023-02-16T08:27:07+00:00

The rsvp classifier has served us well for about a quarter of a century but has
has not been getting much maintenance attention due to lack of known users.

Signed-off-by: Jamal Hadi Salim 
Acked-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

net/sched: Retire tcindex classifier

2023-02-16T08:27:07+00:00

The tcindex classifier has served us well for about a quarter of a century
but has not been getting much TLC due to lack of known users. Most recently
it has become easy prey to syzkaller. For this reason, we are retiring it.

Signed-off-by: Jamal Hadi Salim 
Acked-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

net/sched: Retire dsmark qdisc

2023-02-16T08:27:06+00:00

The dsmark qdisc has served us well over the years for diffserv but has not
been getting much attention due to other more popular approaches to do diffserv
services. Most recently it has become a shooting target for syzkaller. For this
reason, we are retiring it.

Signed-off-by: Jamal Hadi Salim 
Acked-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

net/sched: Retire ATM qdisc

2023-02-16T08:27:06+00:00

The ATM qdisc has served us well over the years but has not been getting much
TLC due to lack of known users. Most recently it has become a shooting target
for syzkaller. For this reason, we are retiring it.

Signed-off-by: Jamal Hadi Salim 
Acked-by: Jiri Pirko 
Signed-off-by: Paolo Abeni