linux.git/tools/testing/selftests/powerpc, branch v5.9-rc2

selftests/powerpc: Fix pkey syscall redefinitions

2020-08-05T00:14:03+00:00

On distros using older glibc versions, the pkey tests encounter build
failures due to redefinition of the pkey syscall numbers.

For compatibility, commit 743f3544fffb added a wrapper for the
gettid() syscall and included syscall.h if the version of glibc used
is older than 2.30. This leads to different definitions of SYS_pkey_*
as the ones in the pkey test header set numeric constants where as the
ones from syscall.h reuse __NR_pkey_*. The compiler complains about
redefinitions since they are different.

This replaces SYS_pkey_* definitions with __NR_pkey_* such that the
definitions in both syscall.h and pkeys.h are alike. This way, if
syscall.h has to be included for compatibility reasons, builds will
still succeed.

Fixes: 743f3544fffb ("selftests/powerpc: Add wrapper for gettid")
Reported-by: Sachin Sant 
Suggested-by: David Laight 
Suggested-by: Michael Ellerman 
Signed-off-by: Sandipan Das 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/a4956d838bf59b0a71a2553c5ca81131ea8b49b9.1596561758.git.sandipan@linux.ibm.com

selftests/powerpc: Skip vmx/vsx/tar/etc tests on older CPUs

2020-08-03T12:12:41+00:00

Some of our tests use VSX or newer VMX instructions, so need to be
skipped on older CPUs to avoid SIGILL'ing.

Similarly TAR was added in v2.07, and the PMU event used in the stcx
fail test only works on Power8 or later.

Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200803020719.96114-1-mpe@ellerman.id.au

selftests/powerpc: Fix online CPU selection

2020-07-30T12:53:50+00:00

The size of the CPU affinity mask must be large enough for
systems with a very large number of CPUs. Otherwise, tests
which try to determine the first online CPU by calling
sched_getaffinity() will fail. This makes sure that the size
of the allocated affinity mask is dependent on the number of
CPUs as reported by get_nprocs_conf().

Fixes: 3752e453f6ba ("selftests/powerpc: Add tests of PMU EBBs")
Reported-by: Shirisha Ganta 
Signed-off-by: Sandipan Das 
Reviewed-by: Kamalesh Babulal 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/a408c4b8e9a23bb39b539417a21eb0ff47bb5127.1596084858.git.sandipan@linux.ibm.com

selftests/powerpc: Return skip code for spectre_v2

2020-07-29T13:47:52+00:00

When running under older versions of qemu of under newer versions with
old machine types, some security features will not be reported to the
guest. This will lead the guest OS to consider itself Vulnerable to
spectre_v2.

So, spectre_v2 test fails in such cases when the host is mitigated and
miss predictions cannot be detected as expected by the test.

Make it return the skip code instead, for this particular case. We
don't want to miss the case when the test fails and the system reports
as mitigated or not affected. But it is not a problem to miss failures
when the system reports as Vulnerable.

Signed-off-by: Thadeu Lima de Souza Cascardo 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200728155039.401445-1-cascardo@canonical.com

selftests/powerpc: Fix CPU affinity for child process

2020-07-29T12:30:34+00:00

On systems with large number of cpus, test fails trying to set
affinity by calling sched_setaffinity() with smaller size for affinity
mask. This patch fixes it by making sure that the size of allocated
affinity mask is dependent on the number of CPUs as reported by
get_nprocs().

Fixes: 00b7ec5c9cf3 ("selftests/powerpc: Import Anton's context_switch2 benchmark")
Reported-by: Shirisha Ganta 
Signed-off-by: Sandipan Das 
Signed-off-by: Harish 
Reviewed-by: Kamalesh Babulal 
Reviewed-by: Satheesh Rajendran 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200609081423.529664-1-harish@linux.ibm.com

selftests/powerpc: Remove powerpc special cases from stack expansion test

2020-07-29T11:02:12+00:00

Now that the powerpc code behaves the same as other architectures we
can drop the special cases we had.

Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200724092528.1578671-5-mpe@ellerman.id.au

selftests/powerpc: Update the stack expansion test

2020-07-29T11:02:12+00:00

Update the stack expansion load/store test to take into account the
new allowance of 4224 bytes below the stack pointer.

Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200724092528.1578671-3-mpe@ellerman.id.au

selftests/powerpc: Add test of stack expansion logic

2020-07-29T11:02:11+00:00

We have custom stack expansion checks that it turns out are extremely
badly tested and contain bugs, surprise. So add some tests that
exercise the code and capture the current boundary conditions.

The signal test currently fails on 64-bit kernels because the 2048
byte allowance for the signal frame is too small, we will fix that in
a subsequent patch.

Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200724092528.1578671-1-mpe@ellerman.id.au

selftests/powerpc: Squash spurious errors due to device removal

2020-07-29T11:02:11+00:00

For drivers that don't have the error handling callbacks we implement
recovery by removing the device and re-probing it. This causes the sysfs
directory for the PCI device to be removed which causes the following
spurious error to be printed when checking the PE state:

Breaking 0005:03:00.0...
./eeh-basic.sh: line 13: can't open /sys/bus/pci/devices/0005:03:00.0/eeh_pe_state: no such file
0005:03:00.0, waited 0/60
0005:03:00.0, waited 1/60
0005:03:00.0, waited 2/60
0005:03:00.0, waited 3/60
0005:03:00.0, waited 4/60
0005:03:00.0, waited 5/60
0005:03:00.0, waited 6/60
0005:03:00.0, waited 7/60
0005:03:00.0, Recovered after 8 seconds

We currently try to avoid this by checking if the PE state file exists
before reading from it. This is however inherently racy so re-work the
state checking so that we only read from the file once, and we squash any
errors that occur while reading.

Fixes: 85d86c8aa52e ("selftests/powerpc: Add basic EEH selftest")
Signed-off-by: Oliver O'Halloran 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20200727010127.23698-1-oohall@gmail.com

selftests/powerpc: Add test for pkey siginfo verification

2020-07-29T11:02:10+00:00

Commit c46241a370a61 ("powerpc/pkeys: Check vma before
returning key fault error to the user") fixes a bug which
causes the kernel to set the wrong pkey in siginfo when a
pkey fault occurs after two competing threads that have
allocated different pkeys, one fully permissive and the
other restrictive, attempt to protect a common page at the
same time. This adds a test to detect the bug.

Signed-off-by: Sandipan Das 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/ce40b6ee270bda52e8f4088578ed2faf7d1d509a.1595821792.git.sandipan@linux.ibm.com