linux.git/tools/testing/selftests/net/forwarding/lib.sh, branch v6.10

selftests/net: use tc rule to filter the na packet

2024-05-21T11:25:11+00:00

Test arp_ndisc_untracked_subnets use tcpdump to filter the unsolicited
and untracked na messages. It set -e before calling tcpdump. But if
tcpdump filters 0 packet, it will return none zero, and cause the script
to exit.

Instead of using slow tcpdump to capture packets, let's using tc rule
to filter out the na message.

At the same time, fix function setup_v6 which only needs one parameter.
Move all the related helpers from forwarding lib.sh to net lib.sh.

Fixes: 0ea7b0a454ca ("selftests: net: arp_ndisc_untracked_subnets: test for arp_accept and accept_untracked_na")
Signed-off-by: Hangbin Liu 
Reviewed-by: Simon Horman 
Link: https://lore.kernel.org/r/20240517010327.2631319-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni

selftests: net: use upstream mtools

2024-05-13T20:54:33+00:00

Joachim kindly merged the IPv6 support in
https://github.com/troglobit/mtools/pull/2, so we can just use his
version now. A few more fixes subsequently came in for IPv6, so even
better.

Check that the deployed mtools version is 3.0 or above. Note that the
version check breaks compatibility with my fork where I didn't bump the
version, but I assume that won't be a problem.

Signed-off-by: Vladimir Oltean 
Link: https://lore.kernel.org/r/20240510112856.1262901-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski

selftests: forwarding: add wait_for_dev() helper

2024-04-26T11:26:53+00:00

The existing setup_wait*() helper family check the status of the
interface to be up. Introduce wait_for_dev() to wait for the netdevice
to appear, for example after test script does manual device bind.

Signed-off-by: Jiri Pirko 
Reviewed-by: Petr Machata 
Reviewed-by: Benjamin Poirier 
Signed-off-by: Paolo Abeni

selftests: forwarding: add check_driver() helper

2024-04-26T11:26:53+00:00

Add a helper to be used to check if the netdevice is backed by specified
driver.

Signed-off-by: Jiri Pirko 
Reviewed-by: Benjamin Poirier 
Signed-off-by: Paolo Abeni

selftests: forwarding: add ability to assemble NETIFS array by driver name

2024-04-26T11:26:53+00:00

Allow driver tests to work without specifying the netdevice names.
Introduce a possibility to search for available netdevices according to
set driver name. Allow test to specify the name by setting
NETIF_FIND_DRIVER variable.

Note that user overrides this either by passing netdevice names on the
command line or by declaring NETIFS array in custom forwarding.config
configuration file.

Signed-off-by: Jiri Pirko 
Reviewed-by: Petr Machata 
Reviewed-by: Benjamin Poirier 
Signed-off-by: Paolo Abeni

selftests: forwarding: bail_on_lldpad() should SKIP

2024-04-16T10:14:41+00:00

$ksft_skip is used to mark selftests that have tooling issues. The fact
that LLDPad is running, but shouldn't, is one such issue. Therefore have
bail_on_lldpad() bail with $ksft_skip.

Signed-off-by: Petr Machata 
Reviewed-by: Benjamin Poirier 
Reviewed-by: Hangbin Liu 
Signed-off-by: Paolo Abeni

selftests: forwarding: lib.sh: Validate NETIFS

2024-04-16T10:14:41+00:00

The variable should contain at least NUM_NETIFS interfaces, stored
as keys named "p$i", for i in `seq $NUM_NETIFS`.

Signed-off-by: Petr Machata 
Reviewed-by: Benjamin Poirier 
Reviewed-by: Hangbin Liu 
Signed-off-by: Paolo Abeni

selftests: net: Unify code of busywait() and slowwait()

2024-04-16T10:14:41+00:00

Bodies of busywait() and slowwait() functions are almost identical. Extract
the common code into a helper, loopy_wait, and convert busywait() and
slowwait() into trivial wrappers.

Moreover, the fact that slowwait() uses seconds for units is really not
intuitive, and the comment does not help much. Instead make the unit part
of the name of the argument to further clarify what units are expected.

Cc: Hangbin Liu 
Signed-off-by: Petr Machata 
Reviewed-by: Benjamin Poirier 
Reviewed-by: Hangbin Liu 
Signed-off-by: Paolo Abeni

selftests: forwarding: router_mpath_nh_lib: Don't skip, xfail on veth

2024-03-29T01:03:43+00:00

When the NH group stats tests are currently run on a veth topology, the
HW-stats leg of each test is SKIP'ped. But kernel networking CI interprets
skips as a sign that tooling is missing, and prompts maintainer
investigation. Lack of capability to pass a test should be expressed as
XFAIL.

Selftests that require HW should normally be put in drivers/net/hw, but
doing so for the NH counter selftests would just lead to a lot of
duplicity.

So instead, introduce a helper, xfail_on_veth(), which can be used to mark
selftests that should XFAIL instead of FAILing when run on a veth topology.
On non-veth topology, they don't do anything.

Use the helper in the HW-stats part of router_mpath_nh_lib selftest.

Signed-off-by: Petr Machata 
Link: https://lore.kernel.org/r/15f0ab9637aa0497f164ec30e83c1c8f53d53719.1711464583.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski

selftests: forwarding: Support for performance sensitive tests

2024-03-29T01:03:43+00:00

Several tests in the suite use large amounts of traffic to e.g. cause
congestion and evaluate RED or shaper performance. These tests will not run
well on a slow machine, be it one with heavy debug kernel, or a VM, or e.g.
a single-board computer. Allow users to specify an environment variable,
KSFT_MACHINE_SLOW=yes, to indicate that the tests are being run on one such
machine.

Performance sensitive tests can then use a new helper, xfail_on_slow(), to
mark parts of the test that are sensitive to low-performance machines.
The helper can be used to just mark the whole suite, like so:

	xfail_on_slow tests_run

... or, on the other side of the granularity spectrum, to override
individual checks:

	xfail_on_slow check_err $? "Expected much, got little."

Signed-off-by: Petr Machata 
Link: https://lore.kernel.org/r/99a376a2d2ffdaeee7752b1910cb0c3ea5d80fbe.1711464583.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski